Error in implementing String comparison in C++

Question

My string s contains 0's and 1's. Why are the values of Ascore and Bscore zero, and not incrementing given the conditions below?

int main()
{
        long long int n;
        string s;
        cin>>n;   // 3
        cin.ignore();
        long long int siz = 2*n, Ascore = 0, Bscore = 0;
        cin>>s; // 101011
        for(int i = 0; i < siz; i++ )
        {

            if((i%2 == 0) && (s[i] == 1))
                Ascore++;
            if((i%2 == 1) && (s[i] == 1))
                Bscore++;
            if(abs(Ascore-Bscore) == 2)
                cout<<i+1<<"\n";
            if((i % 2 == siz-1) && (Ascore == Bscore))
                cout<<i+1<<"\n";


        }

}

s[i] == 1 --> s[i] == '1' etc.

M.M
– M.M

2020-05-08 01:50:21 +00:00
Commented May 8, 2020 at 1:50 — M.M
– M.M, Commented May 8, 2020 at 1:50

cigien · Accepted Answer · 2020-05-08 01:50:53Z

1

A string is composed of chars, so you need to compare against char literals, not ints. e.g.

s[i] == '1'

instead of

s[i] == 1

answered May 8, 2020 at 1:50

cigien

61.2k11 gold badges86 silver badges124 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Hunali · Accepted Answer · 2020-05-08 02:04:51Z

1

You are using a integer 1 instead of character '1'

  for(int i = 0; i < siz; i++ )
        {

            if((i%2 == 0) && (s[i] == '1'))
                Ascore++;
            if((i%2 == 1) && (s[i] == '1'))
                Bscore++;
            if(abs(Ascore-Bscore) == 2)
                cout<<i+1<<"\n";
            if((i % 2 == siz-1) && (Ascore == Bscore))
                cout<<i+1<<"\n";


        }

answered May 8, 2020 at 2:04

Hunali

2771 silver badge12 bronze badges

Collectives™ on Stack Overflow

Error in implementing String comparison in C++

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related