PHP Variable as a parameter in the URL

Question

I want to create weather informer that shows weather forecast by visitor's IP.

I'm trying to place variable $ip to the URL but it doesn't work. When I place real IP instead of .$ip. it works.

What am I doing wrong?

$ip=$_SERVER['REMOTE_ADDR'];
$ch = curl_init();
curl_setopt($ch, CURLOPT_URL, "http://free.worldweatheronline.com/feed/weather.ashx?key=xxxxxxxxxxxxxxx&q=.$ip.&localObsTime&num_of_days=5&format=json");
curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
curl_setopt($ch, CURLOPT_HEADER, 0);
$outputJson = curl_exec($ch);
 if ($outputJson === FALSE) {
 echo 'Error: '.curl_error($ch);
 }

 echo '<pre> ';
 print_r($outputJson);   
 echo '</pre> ';

when you do print_r do you have the correct output at least ? — Tarek
– Tarek, Commented Jun 25, 2011 at 12:36
@Tarek Yes, It returns json data (if IP is real, not a variable) — Vera
– Vera, Commented Jun 25, 2011 at 12:42

Crozin · Accepted Answer · 2011-06-25 12:38:13Z

2

You have got some unnecessary dots before and after $ip:

Use any of following:

"http://...$ip..."
"http://...{$ip}..."
"http://..." . $ip . "...";

answered Jun 25, 2011 at 12:38

Crozin

44.4k13 gold badges92 silver badges136 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

donk · Accepted Answer · 2011-06-25 12:36:15Z

1

Try doing

curl_setopt($ch, CURLOPT_URL, "http://free.worldweatheronline.com/feed/weather.ashx?key=xxxxxxxxxxxxxxx&q=".$ip."&localObsTime&num_of_days=5&format=json");

answered Jun 25, 2011 at 12:36

donk

1,5704 gold badges23 silver badges46 bronze badges

1 Comment

Yasser Souri Over a year ago

because of the double quotes that has no effect.

Mina · Accepted Answer · 2011-06-25 12:58:06Z

1

you don't need to concatenate the string since you're using doublequotes. so you either do:

curl_setopt($ch, CURLOPT_URL, "http://free.worldweatheronline.com/feed/weather.ashx?key=xxxxxxxxxxxxxxx&q=$ip&localObsTime&num_of_days=5&format=json");

in the url.

answered Jun 25, 2011 at 12:58

Mina

7677 silver badges22 bronze badges

Comments

knittl · Accepted Answer · 2011-06-25 12:41:59Z

0

you are using the string concatenation operator inside the string. either use

"http://free.worldweatheronline.com/feed/weather.ashx?key=xxxxxxxxxxxxxxx&q=$ip&localObsTime&num_of_days=5&format=json"

or

'http://free.worldweatheronline.com/feed/weather.ashx?key=xxxxxxxxxxxxxxx&q='.$ip.'&localObsTime&num_of_days=5&format=json'

answered Jun 25, 2011 at 12:41

knittl

269k59 gold badges339 silver badges405 bronze badges

Collectives™ on Stack Overflow

PHP Variable as a parameter in the URL

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related