Simple symmetric encryption with Python [duplicate]

Question

I want to encrypt some letters by changing each letter with the character in echaracters which has the same index as the letter in characters. So, I tried to use zip() to iterate over the two lists. Firstly I iterated over userInput and the within the same loop, I iterated over key (which is zip(characters, echaracters)) Then I check if i is equal to a and if the condition is True i add b to cipher.

userInput = input("Enter: ")

characters = ["A", "B", "C", "D", "E", "F", "G", "H", "I", "J", "K", "L", "M", "N", "O", "P", "Q", "R", "S", "T", "U", "V", "W", "X", "Y", "Z"]

echaracters = ["@", "$", "(", "]", "=", ")", "&", "#", "!", "%", "~", "[", "/", ";", "*", "}", "9", "?", "5", "1", "_", ">", "<<", "+", ",", "-"]

key = zip(characters, echaracters)

cipher = ""

for i in userInput:
    for a, b in key:
        if i == a:
            cipher += b

print(cipher)

OUTPUT

Enter: ABC
@

I cannot figure out why it returns only the first symbol.
DESIRED OUTPUT

Enter: ABC
@$(

What am I doing wrong?

Arseniy · Accepted Answer · 2021-02-02 21:08:22Z

2

Your key becomes empty after the first loop pass

You can try this:

key=list(zip(characters, echaracters))
for i in userInput:
    for a, b in key:        
        if i == a:            
            cipher += b

answered Feb 2, 2021 at 21:08

Arseniy

6905 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Arrcival Over a year ago

This. Or you can make key a list key = list(zip(characters, echaracters)) to prevent this behavior too

Arseniy Over a year ago

I agree, coincidentally, I already added this in answer)

Emanuele Over a year ago

Thank you for the answer

Aven Desta · Accepted Answer · 2021-02-02 21:17:22Z

2

The reason is because 'key', which is a zip-type, loses its value after the first iteration because zip-type is an iterator. Here is a similar question. Your code is a bit complicated. There is easier way to accomplish your task.

userInput = input("Enter: ")
characters = ["A", "B", "C", "D", "E", "F", "G", "H", "I", "J", "K", "L", "M", "N", "O", "P", "Q", "R", "S", "T", "U", "V", "W", "X", "Y", "Z"]
echaracters = ["@", "$", "(", "]", "=", ")", "&", "#", "!", "%", "~", "[", "/", ";", "*", "}", "9", "?", "5", "1", "_", ">", "<<", "+", ",", "-"]

cipher = ""
for i in userInput:
  cipher += echaracters[characters.index(i)]
print(cipher)

edited Feb 2, 2021 at 21:17

answered Feb 2, 2021 at 21:10

Aven Desta

2,4791 gold badge16 silver badges30 bronze badges

Comments

GolangMan · Accepted Answer · 2021-02-02 22:04:30Z

SYBMOLS = {
    "A": "@",
    "B": "$",
    "C": "(",
    "D": "]",
    "E": "=",
    "F": ")",
    "G": "&",
    "H": "#",
    "I": "!",
    "J": "%",
    "K": "~",
    "L": "[",
    "M": "/",
    "N": ";",
    "O": "*",
    "P": "}",
    "Q": "9",
    "R": "?",
    "S": "5",
    "T": "1",
    "U": "_",
    "V": ">",
    "W": "<<",
    "X": "+",
    "Y": ",",
    "Z": "-",
}

userInput = input("Enter: ")

for symbol in userInput:
    print(SYBMOLS[symbol], end="")

Also, if you want just lists and not a dictionary, instead of:

characters = ["A", "B", "C", "D", "E", "F", "G", "H", "I", "J", "K", "L", "M", "N", "O", "P", "Q", "R", "S", "T", "U", "V", "W", "X", "Y", "Z"]

You can use

from string import ascii_uppercase

print(ascii_uppercase) # example zip(ascii_uppercase, echaracters)

# ABCDEFGHIJKLMNOPQRSTUVWXYZ

Collectives™ on Stack Overflow

Simple symmetric encryption with Python [duplicate]

3 Answers 3

3 Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Linked

Related