JavaScript help/ issue with loops

Question

I'm new into this but basically I'm trying to make a JavaScript loop, where 2 fighters fight. I made an array with the 2 fighters and a button connected to my JavaScript from HTML. Now I need to make a loop where the fighters hit each other where the damage by 1 fighter is subtracted by the health of the other so on, later I need to display how the fight went in my html. but I don't know where to start I would be thankful for some help. This is what I have done and I don't know what to do after or if it is even right?

var fighters =  [
{
  "name":"Abdi",
  "HP": 100,
  "DMG": 20,
}
{
  "name": "chriz",
  "HP": 100,
  "DMG": 11,
}

]
function myFunction() {
  for (var i = 0; i < fighters.length; i++) {
    fighters[i]
  }
}

Why do you need a loop? If fighters[0] hits fighters[1], it's just fighters[1].HP -= fighters[0].DMG; — Barmar
– Barmar, Commented Apr 19, 2021 at 19:47
Use loops when the number of elements is dynamic or you need to do the same thing to every element of the array. But that's not the case here. — Barmar
– Barmar, Commented Apr 19, 2021 at 20:13
function myFunction() { for (var i = 0; i < fighters.length; i++) { fighters[1].HP -= fighters[0].DMG; fighters[0].HP -= fighters[1].DMG; } something like this??? — råby
– råby, Commented Apr 19, 2021 at 21:43

S.V. · Accepted Answer · 2021-04-19 19:48:28Z

1

You're doing perfect.

Few things --

fighters[i] refers to a specific fighter. You may want to replace that line with some actual logic, for example fighters[i].HP++ would increase their health by one.
Your fighters array doesn't have a comma. You need one.
You've defined the function that does what you need, but you haven't called it. You may want to call it by adding a line like myFunction();

Also, don't forget to output something or you'll never know what's happening! A lot of people use console.log() for that, e.g. console.log(fighters[i].HP)

(Note: I specifically did not add the logic you mentioned because I believe that's homework ;)

answered Apr 19, 2021 at 19:48

S.V.

1,2218 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Barmar Over a year ago

Where do you talk about one fighter inflicting damage on the other fighter based on their DMG property?

S.V. Over a year ago

I personally refrain from directly answering homework questions as that would be detrimental to the student's development. Feel free to downvote if you disagree.

Barmar Over a year ago

That's fine, but your answer doesn't even address anything in the question.

Barmar Over a year ago

The part about the missing comma should just be a comment, it's clearly a copying error.

Barmar Over a year ago

And the question says he has "a button connected to my javascript from html". That's how the function is called.

råby · Accepted Answer · 2021-04-22 14:48:34Z

0

function myFunction() {

  while (fighters[0].HP > 0 && fighters[1].HP > 0) {
  fighters[1].HP -= fighters[0].DMG;
  fighters[0].HP -= fighters[1].DMG;
  document.getElementById('Results').innerHTML+= fighters[1].HP ;
  document.getElementById('Results').innerHTML+= fighters[0].HP;
}

answered Apr 22, 2021 at 14:48

råby

336 bronze badges

Collectives™ on Stack Overflow

JavaScript help/ issue with loops

2 Answers 2

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related