Update global variables in two functions JavaScript

Question

Though I am aware of "Global scope, function scope, block scope" in JavaScript. I got stuck in this code block.

I simplified the logics of the code as follows. What I expected is, the console.log(a, b, c) in execute function would be a = 3, b = 6, c = 9. But what I actually got is a = 0, b = 0, c = 0. What's going wrong and how to fix this? Thanks

(function() {
    let a,b,c;
    let conditions = [-1, 1, 2, 3 ];

    const execute = () => {
        for (let i=0; i<conditions.length; i++) {
            if (conditions[i] < 0) {
                a = 0;
                b = 0;
                c = 0;
            } else if (conditions[i] > 0) {
                update(a, b, c);
            }
        }
        console.log(a,b,c);
    }

    const update = (a, b, c) => {
        a = a + 1;
        b = b + 2;
        c = c + 3;
    }

    execute();

})()

Your update() function defines its own a, b, and c parameters, which hide the local variables in the external function scope. — Pointy
– Pointy, Commented Apr 16, 2022 at 23:30
To restate @Pointy, the assignments in update() change that function's parameters, which have no relationship to the variables in the containing scope. To get expected results, delete update's params. update = () => ... — danh
– danh, Commented Apr 16, 2022 at 23:32

danh · Accepted Answer · 2022-04-16 23:47:14Z

1

Here, by not declaring params to update(), the assignments are made to the variables in the parent scope.

(function() {
    let a,b,c;
    let conditions = [-1, 1, 2, 3 ];

    const execute = () => {
        for (let i=0; i<conditions.length; i++) {
            if (conditions[i] < 0) {
                a = 0;
                b = 0;
                c = 0;
            } else if (conditions[i] > 0) {
                update(); // edit
            }
        }
        console.log(a,b,c);
    }

    const update = () => {
        a = a + 1;
        b = b + 2;
        c = c + 3;
    }
    execute();
})()

edited Apr 16, 2022 at 23:47

answered Apr 16, 2022 at 23:37

danh

62.7k10 gold badges100 silver badges139 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Judy Over a year ago

Ah... I learned that both the arguments and parameters in update() are unnecessary. Thanks

danh Over a year ago

@Judy - I should have mentioned that the arguments aren't necessary either. Please see edit.

Collectives™ on Stack Overflow

Update global variables in two functions JavaScript

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related