PHP recursive file& folder delete function: 'Directory not empty' error message

Question

I'm trying to create function which removes all file and directories on webhosting excluding given files and folders arrays

function cleanUp($exdirs, $exfiles){
$it = new RecursiveIteratorIterator(
  new RecursiveDirectoryIterator('.'), 
  RecursiveIteratorIterator::CHILD_FIRST
);
foreach($it as $entry) {
  if ($entry->isDir() && !in_array($entry->getBasename(), $exdirs)) {
    rmdir($entry->getPathname());
  }
  else {
    if (!in_array($entry->getFileName(), $exfiles)) {
      unlink($entry->getPathname());
    }
    else {
      $exdirs[] = dirname($entry->getFileName());
    }
  }
}
}

And calling this function like this

$excludeDirsNames = array('cgi-bin');
$excludeFileNames = array('.htaccess', 'ws.zip', 'update.php');
cleanUp($excludeDirsNames , $excludeFileNames);

Now the problem is, it deletes but getting error message: Directory not empty on line rmdir($entry->getPathname()); several times. How to fix that problem?

Is this not here: stackoverflow.com/questions/7685134/…. As you are experiencing an issue with the previous answer, I would sugest you go back to that thread, deselect the answer you approved and ask questions there. If the answer you chose does not work, you should revert your choice so as to not confuse future users how look at the thread. — SW4
– SW4, Commented Oct 7, 2011 at 9:49

KingCrunch · Accepted Answer · 2011-10-07 10:09:36Z

1

You allow to exclude files and directories, but you don't test, if a directory contains other files, or directories, that were excluded before.

if (substr($oneExcludedFileOrDirectory, 0, strlen($currentDir) === $currentDir) {
  echo "Directory not empty";
}

Just a simple prefix comparison: Is "dir" is prefix of one of the excluded paths? Only works for absolute paths (and some other minor things), but it should explain, whats the matter.

edited Oct 7, 2011 at 10:09

answered Oct 7, 2011 at 9:49

KingCrunch

133k22 gold badges158 silver badges174 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

heron Over a year ago

don't get it. how will look like your theory in my function

KingCrunch Over a year ago

When /path/to/my/file starts with /path/to, then /path/to/my/file is in /path/to/ and when you don't delete /path/to/my/file, then /path/to is not empty.

KingCrunch Over a year ago

Better? Now you should be able to integrate it into your code yourself.

heron Over a year ago

it needs to be within foreach loop?

heron Over a year ago

i really can't integrate it to my code. Please show me where it must be

|

fischel · Accepted Answer · 2011-10-07 09:56:57Z

0

Here are two reasons why it not work:

1) In one of your child-folder are files you are excluding. There are not deleted, so it is not possible to "rm" the folder.

2) After the "unlink" and "rmdir"-Funktion call "clearstatcache();". I think this will solve your problem. The files are delete, but the information is still available in the cache.

answered Oct 7, 2011 at 9:56

fischel

111 bronze badge

Collectives™ on Stack Overflow

PHP recursive file& folder delete function: 'Directory not empty' error message

2 Answers 2

6 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related