Java script formatting Rails 3.1

Question

How could I move the javascript from application_helper.rb

Currently I have javascripts in application helper

def js_field_formatter_phone()

 result = <<JS_DATE_FIELD_PHONE
 <script language="javascript" type="text/javascript">

  function js_field_formatter_phone(inputField) {
      var valueStr = inputField.value;
      var formattedStr = "";
      for (var i=0; i<valueStr.length; i++) {
          if (/^\\d/.test(valueStr.charAt(i))) {
              formattedStr += valueStr.charAt(i);
          }
      }
      inputField.value = formattedStr;
  }
 </script>
           JS_DATE_FIELD_PHONE
  return result
end

But this code display as raw html in my views

in my view I've

    <%= js_field_formatter_phone() %>

    <input type="text"
    name="billing_phone_number_home"
    size="30"
    maxlength="20"
    tabindex="<%= get_next_tabindex(@content_data) %>"
    onchange="js_field_formatter_phone(this);"
    value="<%= @content_data['billing_phone_number_home'] %>"

freedrull · Accepted Answer · 2011-10-21 23:03:24Z

1

Rails 3.1 uses the asset pipeline and puts javascripts in app/assets/javascripts. I'm not quite familiar with it yet, you can read about it here: http://guides.rubyonrails.org/asset_pipeline.html

But why is this javascript in a helper at all? It doesn't appear to use the 'result' variable at all.

answered Oct 21, 2011 at 23:03

freedrull

2,2544 gold badges22 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Marnen Laibow-Koser · Accepted Answer · 2011-10-21 21:37:58Z

0

Put the JavaScript in a separate file. Don't mix it in with your HTML.

answered Oct 21, 2011 at 21:37

Marnen Laibow-Koser

6,3651 gold badge31 silver badges34 bronze badges

Collectives™ on Stack Overflow

Java script formatting Rails 3.1

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related