PHP loop syntax issues

Question

I need to add a counter to the loop as well as pulling contents. What is the syntax for adding the "and for ($ColCount = ColCount + 1)"

<?php $ColCount = 0?>
<!--get artwork thumbnails --> 
<?php
$dbname = 'pdartist2';
$table = 'artwork';
// query
$result = mysql_query("SELECT AID, ThumbFilePath, Title, DisplayOrder FROM artwork where SCID = '$SCID' ") or die(mysql_error());
while($row = mysql_fetch_row($result))
{
    foreach($row as $cell)
    and for ($ColCount = ColCount + 1) 

echo "$ColCount", "$cell";
}
mysql_free_result($result);
?>

@The old dog Seeing this questions and these others I suggest you read more on PHP syntax — Damien Pirsy
– Damien Pirsy, Commented Oct 25, 2011 at 15:51

Ry- · Accepted Answer · 2011-10-25 15:45:45Z

2

I have no idea if that's valid in PHP. Maybe all it is is a forgotten $ sign before ColCount. But you could just do it the normal way:

foreach($row as $cell) {
    $ColCount++;

    echo $ColCount . $cell;
}

$ColCount = 0;

answered Oct 25, 2011 at 15:45

Ry-♦

226k56 gold badges496 silver badges504 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Flo Over a year ago

nope your right, the code in the question is very odd. Not sure what is wanted but was going to post the same solution.

Álvaro González Over a year ago

I posted the same solution, except with $ColCount = 0; in the right place, and got a downvote without comments :(

check123 · Accepted Answer · 2011-10-25 15:47:33Z

1

Code:

<!--get artwork thumbnails -->      
<?php  
$dbname = 'pdartist2';  
$table = 'artwork';  
// query  
$result = mysql_query("SELECT AID, ThumbFilePath, Title, DisplayOrder FROM artwork   where SCID = '$SCID' ") or die(mysql_error());  
while($row = mysql_fetch_row($result))  
{  
    $colCount = 0;  
    foreach($row as $cell) {  
      $colCount++;  
      echo "$ColCount", "$cell";  
    }  
}  
 mysql_free_result($result);  

?>

answered Oct 25, 2011 at 15:47

check123

2,0292 gold badges24 silver badges29 bronze badges

1 Comment

The old dog Over a year ago

This place is awesome! How would I add if ColCount is 1 <div id="clear"></div>

Shai Mishali · Accepted Answer · 2011-10-25 15:47:44Z

0

As Bruce said, you could just do $ColCount++, But also you could just count the results with mysql_num_rows

$result = mysql_query("SELECT AID, ThumbFilePath, Title, DisplayOrder FROM artwork where SCID = '$SCID' ") or die(mysql_error());
$numRows = mysql_num_rows($result);

Shai

answered Oct 25, 2011 at 15:47

Shai Mishali

9,4425 gold badges60 silver badges83 bronze badges

1 Comment

Álvaro González Over a year ago

That will provide the number of rows in the result set, not a column count for each row.

PeeHaa · Accepted Answer · 2011-10-25 15:46:25Z

0

You are missing a semi-colon:

<?php $ColCount = 0?>

Should be:

<?php $ColCount = 0; ?>

And:

while($row = mysql_fetch_row($result)) {
    foreach($row as $cell) {
        $ColCount++; // adds 1 to colcount

        echo $ColCount.$cell; // no need for quotes around variables. Also string concatination in PHP is using s dot (.)
    }
 }

mysql_free_result($result);

answered Oct 25, 2011 at 15:46

PeeHaa

73.1k60 gold badges195 silver badges264 bronze badges

4 Comments

Álvaro González Over a year ago

The column count has to be reset for each row. Doing it once on top of the script will just count the total number cells in the result set.

PeeHaa Over a year ago

@ÁlvaroG.Vicario: as you can see I don't only use the total count, but I also print the colcount in the loop. That's what OP wants if I'm correct. I might be wrong though. Bit hard to tell what OP actually wants to achieve... :)

Álvaro González Over a year ago

Yes, but you don't set it back to zero when you start printing a new row.

PeeHaa Over a year ago

@ÁlvaroG.Vicario: I don't know if that is what the OP wants. He only states he needs a counter.

David Bélanger · Accepted Answer · 2011-10-25 15:48:38Z

What i'll do is use an array like that

    <!--get artwork thumbnails --> 
    <?php
    $dbname = 'pdartist2';
    $table = 'artwork';

    # Define array
    $Count = array();

    // query
    $result = mysql_query('SELECT AID, ThumbFilePath, Title, DisplayOrder FROM artwork where SCID = '.$SCID) or die(mysql_error());
    while($row = mysql_fetch_row($result)){
        foreach($row as $cell){
            $Count[$Cell]['Count'] = $Count[$Cell]['Count']++;
        }

        echo $ColCount.', '.$cell;
    }
    mysql_free_result($result);

So you have the count for each colomn but what I suggest is to use the mysql_num_rows(); like that :

$Query = mysql_query... $Count = mysql_num_rows($Query);

$Count will be a number ;)

Then if($Count > 0)

Marc B · Accepted Answer · 2011-10-25 15:52:39Z

0

If you're trying to count the number of columns in each row, then

while($row = mysql_fetch_row($result)) {
   $colCount += count($row);
}

though I fail to see point of this. an SQL result set is a perfectly rectangular array. Variable number of rows, but every row will ALWAYS have the same number of fields as all the other rows in the result set. You'd only have to count the columns ONCE and cache that value.

answered Oct 25, 2011 at 15:52

Marc B

362k44 gold badges433 silver badges508 bronze badges

Collectives™ on Stack Overflow

PHP loop syntax issues

6 Answers 6

2 Comments

1 Comment

1 Comment

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

2 Comments

1 Comment

1 Comment

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related