Ruby on Rails regex

Question

I have these statements in a model:

before_save :add_http

protected
def add_http
  if (/^http\:\/\/.+$/.match(url)) == nil
    str = "http://" + url
    url = str
  end
end

I have checked the regex in the console and it appears to be right, but when the 'url' gets saved to the db the "http://" has not been added. Any ideas?

Sarah Mei · Accepted Answer · 2009-05-09 06:40:52Z

2

Not sure if this matters to you or not, but your regex won't work with https URLs. This should work though:

def add_http
  self.url += "http://" if self.url.match(/^https?\:\/\/.+$/).nil?
end

answered May 9, 2009 at 6:40

Sarah Mei

18.5k5 gold badges47 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user35288 Over a year ago

Thanks, I thought about that but wanted to get the basics working first. By the way, I read your blog about the 'pron star' fiasco, nice article!

user35288 · Accepted Answer · 2009-05-08 16:51:00Z

2

Nevermind, got it...

protected
def add_http
  if (/^http\:\/\/.+$/.match(url)) == nil
    str = "http://" + url
    self.url = str
  end
end

answered May 8, 2009 at 16:51

user35288

Collectives™ on Stack Overflow

Ruby on Rails regex

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related