java: String index out of range: 6

Question

I get the following error in my java code:

Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: 6

...which occurs at the following line:

if (strFactor.charAt(j) == strProduct.charAt(k)) {

Here is the code:

       for (int j=0; 0<=5; j++) {
            same = false;
            for (int k=0; k<=5; k++) {
                if (strFactor.length() == 6 && strProduct.length() == 6) {
                    if (strFactor.charAt(j) == strProduct.charAt(k)) {
                        same = true;
                    }
                }
            }
            if (!same) {
                return false;
            }
        }

Anyone have any idea why the index would ever be out of range?

johnsyweb · Accepted Answer · 2011-12-08 08:30:16Z

1

I'm no Java programmer, but 0<=5 will always evaluate to true, so j reaches 6 (and would keep going were it not for that exception).

answered Dec 8, 2011 at 8:30

johnsyweb

143k26 gold badges197 silver badges253 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

moravec Over a year ago

you have no idea how long i've fretted over this. thanks for pointing out my stupidity! :)

johnsyweb Over a year ago

There have got to be better ways of solving this problem, but that wasn't the question being asked ;-)

hungryMind · Accepted Answer · 2011-12-08 08:31:17Z

1

for (int j=0; 0<=5; j++) { should be for (int j=0; j<=5; j++) {

answered Dec 8, 2011 at 8:31

hungryMind

7,0214 gold badges33 silver badges46 bronze badges

Comments

Mithun Sasidharan · Accepted Answer · 2011-12-08 08:31:36Z

1

Look at the first line of your forloop. The string is going out of bounds

for (int j=0; 0<=5; j++) {

Correct the condition. Always be careful when you code !! Happy Coding

answered Dec 8, 2011 at 8:31

Mithun Sasidharan

21.1k10 gold badges38 silver badges53 bronze badges

Comments

Phoebe Pei · Accepted Answer · 2011-12-08 08:34:26Z

0

Hey man: Your j_for is wrong...It should be for(int j=0; j<=5; j++),but you write 0<=5

answered Dec 8, 2011 at 8:34

Phoebe Pei

1

Collectives™ on Stack Overflow

java: String index out of range: 6

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related