Styling using Javascript Cookie

Question

I seem to be able to retrieve the value of the cookie but the style of the corresponding ID isn't changed. What am I missing?

    function getCookie(name) {
        var cookieName = document.cookie;
        var prefix = name + "=";
        var begin = cookieName.indexOf("; " + prefix);
        if (begin == -1) {
            begin = cookieName.indexOf(prefix);
            if (begin != 0) return null;
        } else begin += 2;
        var end = cookieName.indexOf(";", begin);
        if (end == -1) end = cookieName.length;
        return unescape(cookieName.substring(begin + prefix.length, end));
    }
    var value = getCookie('nameCookie');
    document.getElementById(value).style.height = "10%";

following code also doesn't work

    var value = getCookie('nameCookie');
    if (value == 'test') {
          document.getElementById('test').style.height = "10%";
    }

If you console.log(value) does it contains the ID you are expecting — Tim Wickstrom
– Tim Wickstrom, Commented Mar 14, 2012 at 23:05
@TimWickstrom.com, he say he seems to have retrieved the value — Starx
– Starx, Commented Mar 14, 2012 at 23:07
Missed that, try console.log(document.getElementById(value)); What kind of Element is it? Is it a block element, can it have 10% height? is the parent height defined so the browser can calculate 10%? — Tim Wickstrom
– Tim Wickstrom, Commented Mar 14, 2012 at 23:12

Starx · Accepted Answer · 2012-03-14 23:16:47Z

3

Since you seem to be able to retrieve the value of the cookie the problem is that when the code is running, it cannot find the element because the DOM is not ready yet. Make sure the script is running, after the element is loaded.

Just place your script block just before closing the </body>.

edited Mar 14, 2012 at 23:16

answered Mar 14, 2012 at 23:06

Starx

79.3k50 gold badges187 silver badges266 bronze badges

Sign up to request clarification or add additional context in comments.

11 Comments

Tim D'Haene Over a year ago

doesn't seem to be any difference

Tim Wickstrom Over a year ago

Good call! Spoiled by my own coding habits was not even thinking about if the dom was ready!

Starx Over a year ago

@TimD'Haene, Do you have an element with id what the cookies values is?

Tim D'Haene Over a year ago

yes, even if I changed the getElementById to getElementById('idName') and put the whole thing in an if statement, it still isn't working

Starx Over a year ago

@TimD'Haene, Paste your html on pastebin and post the link on your post. I want to take a look at it.

|

Collectives™ on Stack Overflow

Styling using Javascript Cookie

1 Answer 1

11 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

11 Comments

Your Answer

Sign up or log in

Post as a guest

Related