Skip to content

Conversation

@p-jackson
Copy link
Member

@p-jackson p-jackson commented Sep 11, 2025

Fixes DOTDASH-400

Proposed changes:

Checks the Calypso preferences when rendering the admin bar.
If the user has opt'd in to the Hosting Dashboard, the (W) links will point to the Hosting Dashboard.

CleanShot 2025-09-12 at 11 34 39@2x

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

This is testable, but I don't know how we can merge this ahead of time 🤔 Site front ends don't have the equivalent of wpcalypso that we can deploy to.

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Use wpcalypso.wordpress.com/me/account to opt-in/out of the hosting dashbaord
  • Deploy this change to your sandbox
  • Sandbox your test site
  • Load the test site front end and confirm the (w) links in the top-left point to the correct place.

@p-jackson p-jackson self-assigned this Sep 11, 2025
@p-jackson p-jackson added the [Type] Feature Development of a new feature label Sep 11, 2025
@p-jackson p-jackson requested a review from a team September 11, 2025 23:29
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Sep 11, 2025
@p-jackson p-jackson added the DO NOT MERGE don't merge it! label Sep 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the DOTDASH-400-top-bar-links-to-v2 branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin DOTDASH-400-top-bar-links-to-v2

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@jp-launch-control
Copy link

jp-launch-control bot commented Sep 11, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-bar/wpcom-admin-bar.php 61/289 (21.11%) 21.11% -64 💚

Full summary · PHP report

__( 'All Sites', 'jetpack-mu-wpcom' ) .
'</span>',
'href' => maybe_add_origin_site_id_to_url( 'https://wordpress.com/sites' ),
'href' => maybe_add_origin_site_id_to_url( $hosting_dashboard ? 'https://wordpress.com/v2/sites' : 'https://wordpress.com/sites' ),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've marked as "do not merge" because this doesn't feel safe to merge for a12s—or anyone who has opt'd in to the hosting dashboard.

Until the dashboard/v2 feature flag is enabled on production, this link will be broken.

@p-jackson p-jackson marked this pull request as ready for review September 12, 2025 00:24
@p-jackson p-jackson removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 9, 2025
@p-jackson p-jackson force-pushed the DOTDASH-400-top-bar-links-to-v2 branch from c1331ef to 2e5a8e4 Compare October 16, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants