-
Notifications
You must be signed in to change notification settings - Fork 843
Admin Bar: The admin bar links to Hosting Dashboard, if that is the preference #45155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryCoverage changed in 1 file.
|
| __( 'All Sites', 'jetpack-mu-wpcom' ) . | ||
| '</span>', | ||
| 'href' => maybe_add_origin_site_id_to_url( 'https://wordpress.com/sites' ), | ||
| 'href' => maybe_add_origin_site_id_to_url( $hosting_dashboard ? 'https://wordpress.com/v2/sites' : 'https://wordpress.com/sites' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've marked as "do not merge" because this doesn't feel safe to merge for a12s—or anyone who has opt'd in to the hosting dashboard.
Until the dashboard/v2 feature flag is enabled on production, this link will be broken.
c1331ef to
2e5a8e4
Compare
Fixes DOTDASH-400
Proposed changes:
Checks the Calypso preferences when rendering the admin bar.
If the user has opt'd in to the Hosting Dashboard, the (W) links will point to the Hosting Dashboard.
Other information:
Jetpack product discussion
This is testable, but I don't know how we can merge this ahead of time 🤔 Site front ends don't have the equivalent of
wpcalypsothat we can deploy to.Does this pull request change what data or activity we track or use?
No
Testing instructions:
wpcalypso.wordpress.com/me/accountto opt-in/out of the hosting dashbaord