Forms: Try a horizontal form variation #45234

enejb · 2025-09-18T23:01:46Z

This PR makes it easier to create horizontal forms.
By adding a new horizontal form variation.

This is juts an exploration if this is the way we want to go.

Proposed changes:

Make a new horizontal form variation.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

In the editor.
Add a new form. Select the new horizontal form variation.
Does it look as you would expect? Does it load on the front end as you would expect.

github-actions · 2025-09-18T23:02:33Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the try/horizontal-form-variation branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack try/horizontal-form-variation

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-09-18T23:02:51Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: October 7, 2025
- Code freeze: October 6, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2025-09-18T23:11:27Z

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form.php	587/1100 (53.36%)	-0.24%	5 💔

Full summary · PHP report · JS report

_{If appropriate, add one of these labels to override the failing coverage check:

Covered by non-unit tests
Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code

Coverage tests to be added later
Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.}

projects/packages/forms/src/blocks/contact-form/variations.js

simison · 2025-09-19T06:29:44Z

projects/packages/forms/src/blocks/contact-form/variations.js

+				<>
+					<Path fillRule="evenodd" clipRule="evenodd" d="M18 9H13V7.5H18V9Z" />
+					<Path
+						fillRule="evenodd"
+						clipRule="evenodd"
+						d="M9.5 7.5H7.5V9.5H9.5V7.5ZM7.5 6H9.5C10.3284 6 11 6.67157 11 7.5V9.5C11 10.3284 10.3284 11 9.5 11H7.5C6.67157 11 6 10.3284 6 9.5V7.5C6 6.67157 6.67157 6 7.5 6Z"
+					/>
+					<Path
+						fillRule="evenodd"
+						clipRule="evenodd"
+						d="M19 4.5H5C4.72386 4.5 4.5 4.72386 4.5 5V19C4.5 19.2761 4.72386 19.5 5 19.5H19C19.2761 19.5 19.5 19.2761 19.5 19V5C19.5 4.72386 19.2761 4.5 19 4.5ZM5 3C3.89543 3 3 3.89543 3 5V19C3 20.1046 3.89543 21 5 21H19C20.1046 21 21 20.1046 21 19V5C21 3.89543 20.1046 3 19 3H5Z"
+					/>
+				</>


TODO: if we move forward with this approach, let's check with Ilona to design an icon.

projects/packages/forms/src/blocks/contact-form/variations.js

Introduces a new 'horizontal' variation for the contact form block, allowing fields to be displayed side by side. Updates JS logic, SCSS editor styles, and frontend styles to support the horizontal layout, including responsive adjustments for mobile screens. Apply suggestions from code review - use includes instead of indexOf - use "Subscribe" as default button label Co-authored-by: Douglas Henri <dhasilva@users.noreply.github.com> Co-authored-by: Mikael Korpela <mikael@ihminen.org>

github-actions · 2025-11-25T21:50:05Z

This PR has been marked as stale. This happened because:

It has been inactive for the past 3 months.
It hasn't been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Status] Keep Open`, etc.

If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

If the PR is not updated (or at least commented on) in another month, it will be automatically closed.

enejb requested a review from a team September 18, 2025 23:01

enejb added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Package] Forms labels Sep 18, 2025

github-actions bot added [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Sep 18, 2025

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Sep 18, 2025

dhasilva added the [Status] Needs Review This PR is ready for review. label Sep 18, 2025

dhasilva assigned enejb Sep 18, 2025

dhasilva removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Sep 18, 2025

dhasilva reviewed Sep 18, 2025

View reviewed changes

projects/packages/forms/src/blocks/contact-form/variations.js Outdated Show resolved Hide resolved

simison reviewed Sep 19, 2025

View reviewed changes

projects/packages/forms/src/blocks/contact-form/variations.js Outdated Show resolved Hide resolved

CGastrell force-pushed the try/horizontal-form-variation branch from adb0663 to 5ee7660 Compare September 19, 2025 14:36

enejb and others added 5 commits September 19, 2025 15:01

changelog

71a547a

Fix error messages

a21d076

remove useless css class assigned to form

56a5a94

switch from is-horizontal to variation-horizontal

a1e4dd4

CGastrell force-pushed the try/horizontal-form-variation branch from 26f7658 to a1e4dd4 Compare September 19, 2025 18:04

github-actions bot added the [Status] Stale label Nov 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Forms: Try a horizontal form variation #45234

Forms: Try a horizontal form variation #45234

Uh oh!

enejb commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

simison Sep 19, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Forms: Try a horizontal form variation #45234

Are you sure you want to change the base?

Forms: Try a horizontal form variation #45234

Uh oh!

Conversation

enejb commented Sep 18, 2025

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Uh oh!

simison Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot commented Sep 18, 2025 •

edited

Loading

github-actions bot commented Sep 18, 2025 •

edited

Loading

jp-launch-control bot commented Sep 18, 2025 •

edited

Loading