Atomic: Modify `/sites/%s` endpoint to rely on the privacy model #45600

sergeymitr · 2025-10-23T00:00:13Z

Proposed changes:

Modify the /sites/%s endpoint to make is_private property reflect the actual AT privacy model instead of the cache site's blog_public property.
Introduce new maybe_fix_private_site_option() function to automatically adjust local blog_public option to match the privacy model.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://linear.app/a8c/issue/CONNECT-47

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Create a WoA dev blog (p9o2xV-1r2-p2), install Jetpack Beta.
Use Jetpack Beta to checkout the branch for "Jetpack" and "WordPress.com Site Helper" plugins.
Launch the site, then go to /wp-admin/options-reading.php and make it "private".
Go to /wp-admin/options.php and check the blog_public value. Confirm it's -1, then change it to 1.
Go to https://wordpress.com/sites/your-site-slug. It will send the API request that will trigger the option change.
Refresh the options page, confirm the blog_public value got switched back to -1.
Check log2logstash for feature:atomic_private_site_blog_public_adjusted. Confirm there's a record indicating the option change. Confirm properties.current_value and properties.new_value are correct.
Go back to /wp-admin/options.php and make the site "Public", then repeat steps 4-7 with the different values (change the option to -1, then confirm it got auto-reverted to 1).
Go to /wp-admin/options.php and switch the site to "Coming Soon". Then change the option value to 1 or -1.
Visit https://wordpress.com/sites/your-site-slug and confirm the option value stayed the same (we don't do auto-adjustment for "coming soon" sites).

github-actions · 2025-10-23T00:01:12Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/atomic-site-endpoint-is-private branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/atomic-site-endpoint-is-private

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-10-23T00:01:32Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: November 4, 2025
- Code freeze: November 3, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2025-10-23T00:09:38Z

Code Coverage Summary

Coverage changed in 2 files.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/wpcomsh/private-site/private-site.php	61/335 (18.21%)	-1.53%	26 💔
projects/plugins/jetpack/sal/class.json-api-site-jetpack.php	2/101 (1.98%)	-0.10%	5 💔

Full summary · PHP report · JS report

_{If appropriate, add one of these labels to override the failing coverage check:

Covered by non-unit tests
Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code

Coverage tests to be added later
Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.}

coder-karen

Tests well! Left a comment, but not a blocker.

coder-karen · 2025-10-27T16:50:15Z

projects/plugins/wpcomsh/private-site/private-site.php

+		)
+	);
+
+	wp_remote_post( 'https://public-api.wordpress.com/rest/v1.1/logstash', array( 'body' => array( 'params' => $data ) ) );


This is interesting, I see the same approach to logging was used in another location in wpcomsh as well. Do you think that the number of log entries will be reasonable? Also, what is the purpose of logging the value changes - is it to help debug issues that might arise on individual sites? We could see whether the option was updated via sync, but not what value at what time, so I guess if the history was important it makes sense to log. 🤔

This is just for general monitoring and potential debugging, we'll see if we actually need the data.
I don't expect the number to be too big. And since only Atomic is affected, it all should work pretty fast.
Removing it wouldn't be hard either, since Atomic runs on fresh Jetpack versions.

Atomic: Auto-adjust 'blog_public' property to match privacy model.

97ee164

sergeymitr self-assigned this Oct 23, 2025

sergeymitr added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Platform] Atomic labels Oct 23, 2025

sergeymitr mentioned this pull request Oct 23, 2025

JSON API: Add is_private_site flag for /sites/%s endpoint #45574

Closed

3 tasks

github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Wpcomsh labels Oct 23, 2025

sergeymitr added 3 commits October 23, 2025 15:08

Save option updates to log2logstash.

5399786

Adjust namespace chain in function calls.

6173623

Silence phan false-positives.

d9c0b63

sergeymitr force-pushed the update/atomic-site-endpoint-is-private branch from 53c422b to d9c0b63 Compare October 24, 2025 00:48

sergeymitr added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Oct 24, 2025

sergeymitr requested a review from a team October 24, 2025 13:55

coder-karen previously approved these changes Oct 27, 2025

View reviewed changes

sergeymitr added 2 commits October 29, 2025 09:47

Merge branch 'trunk' into update/atomic-site-endpoint-is-private

229b5fc

Do not update the '0' value.

07490bb

sergeymitr dismissed coder-karen’s stale review via 07490bb October 29, 2025 16:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Atomic: Modify `/sites/%s` endpoint to rely on the privacy model #45600

Atomic: Modify `/sites/%s` endpoint to rely on the privacy model #45600

sergeymitr commented Oct 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 23, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Oct 23, 2025 •

edited

Loading

Uh oh!

coder-karen left a comment

Uh oh!

coder-karen Oct 27, 2025

Uh oh!

sergeymitr Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Atomic: Modify /sites/%s endpoint to rely on the privacy model #45600

Are you sure you want to change the base?

Atomic: Modify /sites/%s endpoint to rely on the privacy model #45600

Conversation

sergeymitr commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

coder-karen left a comment

Choose a reason for hiding this comment

Uh oh!

coder-karen Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

sergeymitr Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Atomic: Modify `/sites/%s` endpoint to rely on the privacy model #45600

Atomic: Modify `/sites/%s` endpoint to rely on the privacy model #45600

sergeymitr commented Oct 23, 2025 •

edited

Loading

github-actions bot commented Oct 23, 2025 •

edited

Loading

github-actions bot commented Oct 23, 2025 •

edited

Loading

jp-launch-control bot commented Oct 23, 2025 •

edited

Loading