-
Notifications
You must be signed in to change notification settings - Fork 843
Forms: Fix default background color #45866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryCoverage changed in 1 file.
|
|
There isn't support for Edit: and actually the same question for regular text inputs. :-) |
|
We need to carefully test all fields in enough themes. Sometimes glitches come just from the fact that themes have very tough specificity rules and others just have widely generic rules that get applied to our elements. Animated and Outlined styles are also a concern in the test matrix. That said, this mostly works on my tests. There seems to be a glitch on some themes using Outlined style and the phone field. Outlined style is always a bit glitchy and difficult to work with since it changes the markup structure. |
I haven't looked into this in detail but I noticed that our selectors are are currently wrapped with a The current checkbox implementation doesn't have such |
I did test across a lot of themes and this worked as expected for me. I need to see how this impacts the phone field as well. To make sure that it works as expected. |
Updates JS to use a white fallback when input background is transparent. Changes SCSS to use a CSS variable for checked input background color, improving consistency with theme text color.
45ee841 to
2019276
Compare
|
Some themes to keep testing that have been problematic:
|
Related to FORMS-299
This PR fixes the default input colour to be White. Which is the expected colour for inputs when no input is set.
This happends on the Ravington as well as the default Twenty-Twenty One theme.
Fixes THEME-85
Before Revington theme.
After:
This also
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: