Users: Add new page to display private viewers #46000

mmtr · 2025-11-19T16:22:59Z

Fixes DOTSITE-14

Proposed changes:

Registers a new "Users > Private Viewers" on private sites where users can view and manage the viewers that have access to the site:

Since integrating the viewers in wp-admin/users.php screen is not worth it given the complexity required (see 171239-ghe-Automattic/wpcom), this PR explores a separate table as a middle ground solution.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Apply these changes to your WP.com private site
Go to wordpress.com/people/team and select your WP.com private site
Add some viewers
Go to Users > Private Viewers
Make sure you can see all the viewers
Make sure you can remove active viewers
Make sure you can resend invites to pending viewers
Make sure you can remove pending invites
Make sure the primary "Add viewer" button redirects to the relevant "add new user" screen depending on the site and admin interface
Go to Settings > Reading and make your site public
Make sure that Users > Private Viewers is not available
Make sure these changes work on both Simple and Atomic

github-actions · 2025-11-19T16:24:04Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

github-actions · 2025-11-19T16:26:19Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the dotsite-14-viewers-not-displayed-in-classic-wp-admin-dashboard branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack dotsite-14-viewers-not-displayed-in-classic-wp-admin-dashboard

bin/jetpack-downloader test jetpack-mu-wpcom-plugin dotsite-14-viewers-not-displayed-in-classic-wp-admin-dashboard

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

jp-launch-control · 2025-11-19T16:42:13Z

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/class-jetpack-mu-wpcom.php	0/328 (0.00%)	0.00%	1 ❤️‍🩹

1 file is newly checked for coverage.

File	Coverage
projects/packages/jetpack-mu-wpcom/src/features/private-viewers/private-viewers.php	0/32 (0.00%) 💔

Full summary · PHP report · JS report

_{Coverage check overridden by

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.
.}

…-wp-admin-dashboard

mmtr · 2025-11-28T15:44:41Z

projects/packages/jetpack-mu-wpcom/src/features/private-viewers/use-viewers.ts

+	// Helper function to fetch a single batch of invites.
+	const fetchInvitesBatch = async ( offset: number ) => {
+		const path = addQueryArgs( `/sites/${ window.wpcomPrivateViewers.siteId }/invites`, {
+			offset,
+			number: batchSize,
+			status: 'all',
+			role: window.wpcomPrivateViewers.viewerRole,
+		} );
+		return await wpcomRequest< { invites: Invite[]; found: number } >( {
+			path,
+			apiVersion: '1',
+		} );
+	};


For some reason this request is not triggered on Atomic sites, even though there are no JS errors 🤔

The wpcomPrivateViewers global is defined, so I don't know what's going here.

mmtr added 6 commits November 19, 2025 13:47

Add empty private-viewers.php feature

1d6f0cc

Add menu that displays an empty page

1b806f4

Add basic React component

d5354dd

Render dataview and fetch viewers from API

23dfec1

Implement pagination

16d49e6

Add changelog

98ac558

mmtr self-assigned this Nov 19, 2025

mmtr added [Status] In Progress [Type] Task I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. labels Nov 19, 2025

github-actions bot added [Package] Jetpack mu wpcom WordPress.com Features [mu wpcom Feature] Private Viewers labels Nov 19, 2025

Disable search and sorting

01e00b6

mmtr added 14 commits November 19, 2025 18:25

Polish layout

4acffa7

Better loading status

97d2470

Bail on non-private sites

f6738ec

Better empty layout

8f2a42f

Render avatar

463698f

Move pagination to frontend and fetch all viewers

7ea865a

Add filtering and sorting

317be86

Add status column

840bb0a

Fetch all viewers (incl. pending viewers)

26b4ca5

Add more columns

7618625

Add removal logic

204f35f

Add resend logic

3689d22

move global ts to main file

2326064

Support Atomic sites

e15091f

mmtr added 10 commits November 21, 2025 15:45

Include basic "Add viewer" button

7967e23

Display notices

3d06258

Add text domain to dataviews translations

f1d7938

Reset pnpm-lock.yaml

e300389

Merge branch 'trunk' into dotsite-14-viewers-not-displayed-in-classic…

dd15264

…-wp-admin-dashboard

Update pnpm-lock.yaml

7b1eca5

add missing dep

5c93f52

regenerate pnpm-lock

4799524

Try avoiding bad minification

32a463c

Fix i18n errors during build

6f47b9e

mmtr commented Nov 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Users: Add new page to display private viewers #46000

Users: Add new page to display private viewers #46000

Uh oh!

mmtr commented Nov 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 19, 2025

Uh oh!

github-actions bot commented Nov 19, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Nov 19, 2025 •

edited

Loading

Uh oh!

mmtr Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Users: Add new page to display private viewers #46000

Are you sure you want to change the base?

Users: Add new page to display private viewers #46000

Uh oh!

Conversation

mmtr commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Nov 19, 2025

Uh oh!

github-actions bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

mmtr Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mmtr commented Nov 19, 2025 •

edited

Loading

github-actions bot commented Nov 19, 2025 •

edited

Loading

jp-launch-control bot commented Nov 19, 2025 •

edited

Loading