Skip to content

Commit 53f537d

Browse files
committed
No need to :nodoc: private methods
1 parent a43e770 commit 53f537d

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

activemodel/lib/active_model/attribute_methods.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -349,11 +349,11 @@ def instance_method_already_implemented?(method_name) #:nodoc:
349349
# used to alleviate the GC, which ultimately also speeds up the app
350350
# significantly (in our case our test suite finishes 10% faster with
351351
# this cache).
352-
def attribute_method_matchers_cache #:nodoc:
352+
def attribute_method_matchers_cache
353353
@attribute_method_matchers_cache ||= Concurrent::Map.new(initial_capacity: 4)
354354
end
355355

356-
def attribute_method_matchers_matching(method_name) #:nodoc:
356+
def attribute_method_matchers_matching(method_name)
357357
attribute_method_matchers_cache.compute_if_absent(method_name) do
358358
# Must try to match prefixes/suffixes first, or else the matcher with no prefix/suffix
359359
# will match every time.
@@ -365,7 +365,7 @@ def attribute_method_matchers_matching(method_name) #:nodoc:
365365
# Define a method `name` in `mod` that dispatches to `send`
366366
# using the given `extra` args. This falls back on `define_method`
367367
# and `send` if the given names cannot be compiled.
368-
def define_proxy_call(include_private, mod, name, send, *extra) #:nodoc:
368+
def define_proxy_call(include_private, mod, name, send, *extra)
369369
defn = if NAME_COMPILABLE_REGEXP.match?(name)
370370
"def #{name}(*args)"
371371
else

activemodel/lib/active_model/callbacks.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,19 +122,19 @@ def define_model_callbacks(*callbacks)
122122

123123
private
124124

125-
def _define_before_model_callback(klass, callback) #:nodoc:
125+
def _define_before_model_callback(klass, callback)
126126
klass.define_singleton_method("before_#{callback}") do |*args, &block|
127127
set_callback(:"#{callback}", :before, *args, &block)
128128
end
129129
end
130130

131-
def _define_around_model_callback(klass, callback) #:nodoc:
131+
def _define_around_model_callback(klass, callback)
132132
klass.define_singleton_method("around_#{callback}") do |*args, &block|
133133
set_callback(:"#{callback}", :around, *args, &block)
134134
end
135135
end
136136

137-
def _define_after_model_callback(klass, callback) #:nodoc:
137+
def _define_after_model_callback(klass, callback)
138138
klass.define_singleton_method("after_#{callback}") do |*args, &block|
139139
options = args.extract_options!
140140
options[:prepend] = true

0 commit comments

Comments
 (0)