Skip to content

Commit 589da3c

Browse files
committed
No need to nodoc private methods
1 parent cdb9d7f commit 589da3c

File tree

5 files changed

+24
-24
lines changed

5 files changed

+24
-24
lines changed

actionpack/lib/action_controller/metal/instrumentation.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,14 +83,14 @@ def halted_callback_hook(filter)
8383
# end
8484
#
8585
# :api: plugin
86-
def cleanup_view_runtime #:nodoc:
86+
def cleanup_view_runtime
8787
yield
8888
end
8989

9090
# Every time after an action is processed, this method is invoked
9191
# with the payload, so you can add more information.
9292
# :api: plugin
93-
def append_info_to_payload(payload) #:nodoc:
93+
def append_info_to_payload(payload)
9494
payload[:view_runtime] = view_runtime
9595
end
9696

actionpack/lib/action_controller/metal/params_wrapper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ def name
135135
#
136136
# This method also does namespace lookup. Foo::Bar::UsersController will
137137
# try to find Foo::Bar::User, Foo::User and finally User.
138-
def _default_wrap_model #:nodoc:
138+
def _default_wrap_model
139139
return nil if klass.anonymous?
140140
model_name = klass.name.sub(/Controller$/, "").classify
141141

actionpack/lib/action_controller/metal/rendering.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,14 @@ def _set_rendered_content_type(format)
7373
end
7474

7575
# Normalize arguments by catching blocks and setting them on :update.
76-
def _normalize_args(action = nil, options = {}, &blk) #:nodoc:
76+
def _normalize_args(action = nil, options = {}, &blk)
7777
options = super
7878
options[:update] = blk if block_given?
7979
options
8080
end
8181

8282
# Normalize both text and status options.
83-
def _normalize_options(options) #:nodoc:
83+
def _normalize_options(options)
8484
_normalize_text(options)
8585

8686
if options[:html]
@@ -103,7 +103,7 @@ def _normalize_text(options)
103103
end
104104

105105
# Process controller specific options, as status, content-type and location.
106-
def _process_options(options) #:nodoc:
106+
def _process_options(options)
107107
status, content_type, location = options.values_at(:status, :content_type, :location)
108108

109109
self.status = status if status

actionpack/lib/action_dispatch/http/mime_type.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ def method_missing(method, *args)
297297
end
298298
end
299299

300-
def respond_to_missing?(method, include_private = false) #:nodoc:
300+
def respond_to_missing?(method, include_private = false)
301301
method.to_s.ends_with? "?"
302302
end
303303
end

actionpack/lib/action_dispatch/routing/mapper.rb

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -996,65 +996,65 @@ def defaults(defaults = {})
996996
end
997997

998998
private
999-
def merge_path_scope(parent, child) #:nodoc:
999+
def merge_path_scope(parent, child)
10001000
Mapper.normalize_path("#{parent}/#{child}")
10011001
end
10021002

1003-
def merge_shallow_path_scope(parent, child) #:nodoc:
1003+
def merge_shallow_path_scope(parent, child)
10041004
Mapper.normalize_path("#{parent}/#{child}")
10051005
end
10061006

1007-
def merge_as_scope(parent, child) #:nodoc:
1007+
def merge_as_scope(parent, child)
10081008
parent ? "#{parent}_#{child}" : child
10091009
end
10101010

1011-
def merge_shallow_prefix_scope(parent, child) #:nodoc:
1011+
def merge_shallow_prefix_scope(parent, child)
10121012
parent ? "#{parent}_#{child}" : child
10131013
end
10141014

1015-
def merge_module_scope(parent, child) #:nodoc:
1015+
def merge_module_scope(parent, child)
10161016
parent ? "#{parent}/#{child}" : child
10171017
end
10181018

1019-
def merge_controller_scope(parent, child) #:nodoc:
1019+
def merge_controller_scope(parent, child)
10201020
child
10211021
end
10221022

1023-
def merge_action_scope(parent, child) #:nodoc:
1023+
def merge_action_scope(parent, child)
10241024
child
10251025
end
10261026

1027-
def merge_via_scope(parent, child) #:nodoc:
1027+
def merge_via_scope(parent, child)
10281028
child
10291029
end
10301030

1031-
def merge_format_scope(parent, child) #:nodoc:
1031+
def merge_format_scope(parent, child)
10321032
child
10331033
end
10341034

1035-
def merge_path_names_scope(parent, child) #:nodoc:
1035+
def merge_path_names_scope(parent, child)
10361036
merge_options_scope(parent, child)
10371037
end
10381038

1039-
def merge_constraints_scope(parent, child) #:nodoc:
1039+
def merge_constraints_scope(parent, child)
10401040
merge_options_scope(parent, child)
10411041
end
10421042

1043-
def merge_defaults_scope(parent, child) #:nodoc:
1043+
def merge_defaults_scope(parent, child)
10441044
merge_options_scope(parent, child)
10451045
end
10461046

1047-
def merge_blocks_scope(parent, child) #:nodoc:
1047+
def merge_blocks_scope(parent, child)
10481048
merged = parent ? parent.dup : []
10491049
merged << child if child
10501050
merged
10511051
end
10521052

1053-
def merge_options_scope(parent, child) #:nodoc:
1053+
def merge_options_scope(parent, child)
10541054
(parent || {}).merge(child)
10551055
end
10561056

1057-
def merge_shallow_scope(parent, child) #:nodoc:
1057+
def merge_shallow_scope(parent, child)
10581058
child ? true : false
10591059
end
10601060

@@ -1868,7 +1868,7 @@ def using_match_shorthand?(path)
18681868
path =~ %r{^/?[-\w]+/[-\w/]+$}
18691869
end
18701870

1871-
def decomposed_match(path, controller, options, _path, to, via, formatted, anchor, options_constraints) # :nodoc:
1871+
def decomposed_match(path, controller, options, _path, to, via, formatted, anchor, options_constraints)
18721872
if on = options.delete(:on)
18731873
send(on) { decomposed_match(path, controller, options, _path, to, via, formatted, anchor, options_constraints) }
18741874
else
@@ -1883,7 +1883,7 @@ def decomposed_match(path, controller, options, _path, to, via, formatted, ancho
18831883
end
18841884
end
18851885

1886-
def add_route(action, controller, options, _path, to, via, formatted, anchor, options_constraints) # :nodoc:
1886+
def add_route(action, controller, options, _path, to, via, formatted, anchor, options_constraints)
18871887
path = path_for_action(action, _path)
18881888
raise ArgumentError, "path is required" if path.blank?
18891889

0 commit comments

Comments
 (0)