Class.new in AR test subclass ApplicationRecord

Before they were subclassing ActiveRecord::Base. With the introduction
of ApplicationRecord, these tests should actually be subclassing
ApplicationRecord.

Author: wangjohn

activerecord/test/cases/adapters/mysql/schema_test.rb

@@ -13,7 +13,7 @@ def setup
         table       = Post.table_name
         @db_name    = db
 
-        @omgpost = Class.new(ActiveRecord::Base) do
+        @omgpost = Class.new(ApplicationRecord) do
           self.table_name = "#{db}.#{table}"
           def self.name; 'Post'; end
         end

activerecord/test/cases/adapters/mysql2/schema_test.rb

@@ -13,7 +13,7 @@ def setup
         table       = Post.table_name
         @db_name    = db
 
-        @omgpost = Class.new(ActiveRecord::Base) do
+        @omgpost = Class.new(ApplicationRecord) do
           self.table_name = "#{db}.#{table}"
           def self.name; 'Post'; end
         end

activerecord/test/cases/associations/has_many_associations_test.rb

@@ -110,11 +110,11 @@ def test_sti_subselect_count
   end
 
   def test_anonymous_has_many
-    developer = Class.new(ActiveRecord::Base) {
+    developer = Class.new(ApplicationRecord) {
       self.table_name = 'developers'
       dev = self
 
-      developer_project = Class.new(ActiveRecord::Base) {
+      developer_project = Class.new(ApplicationRecord) {
         self.table_name = 'developers_projects'
         belongs_to :developer, :class => dev
       }

activerecord/test/cases/associations/has_many_through_associations_test.rb

@@ -60,7 +60,7 @@ def test_preload_sti_middle_relation
   end
 
   def make_model(name)
-    Class.new(ActiveRecord::Base) { define_singleton_method(:name) { name } }
+    Class.new(ApplicationRecord) { define_singleton_method(:name) { name } }
   end
 
   def test_ordered_habtm

activerecord/test/cases/associations/inverse_associations_test.rb

@@ -128,15 +128,15 @@ def test_polymorphic_relationships_should_still_not_have_inverses_when_non_polym
 class InverseAssociationTests < ActiveRecord::TestCase
   def test_should_allow_for_inverse_of_options_in_associations
     assert_nothing_raised(ArgumentError, 'ActiveRecord should allow the inverse_of options on has_many') do
-      Class.new(ActiveRecord::Base).has_many(:wheels, :inverse_of => :car)
+      Class.new(ApplicationRecord).has_many(:wheels, :inverse_of => :car)
     end
 
     assert_nothing_raised(ArgumentError, 'ActiveRecord should allow the inverse_of options on has_one') do
-      Class.new(ActiveRecord::Base).has_one(:engine, :inverse_of => :car)
+      Class.new(ApplicationRecord).has_one(:engine, :inverse_of => :car)
     end
 
     assert_nothing_raised(ArgumentError, 'ActiveRecord should allow the inverse_of options on belongs_to') do
-      Class.new(ActiveRecord::Base).belongs_to(:car, :inverse_of => :driver)
+      Class.new(ApplicationRecord).belongs_to(:car, :inverse_of => :driver)
     end
   end
 

activerecord/test/cases/associations/join_model_test.rb

@@ -743,7 +743,7 @@ def test_has_many_with_pluralize_table_names_false
     def find_post_with_dependency(post_id, association, association_name, dependency)
       class_name = "PostWith#{association.to_s.classify}#{dependency.to_s.classify}"
       Post.find(post_id).update_columns type: class_name
-      klass = Object.const_set(class_name, Class.new(ActiveRecord::Base))
+      klass = Object.const_set(class_name, Class.new(ApplicationRecord))
       klass.table_name = 'posts'
       klass.send(association, association_name, :as => :taggable, :dependent => dependency)
       klass.find(post_id)

activerecord/test/cases/associations_test.rb

@@ -90,7 +90,7 @@ def test_include_with_order_works
 
   def test_bad_collection_keys
     assert_raise(ArgumentError, 'ActiveRecord should have barked on bad collection keys') do
-      Class.new(ActiveRecord::Base).has_many(:wheels, :name => 'wheels')
+      Class.new(ApplicationRecord).has_many(:wheels, :name => 'wheels')
     end
   end
 

activerecord/test/cases/attribute_methods_test.rb

@@ -19,7 +19,7 @@ class AttributeMethodsTest < ActiveRecord::TestCase
 
   def setup
     @old_matchers = ActiveRecord::Base.send(:attribute_method_matchers).dup
-    @target = Class.new(ActiveRecord::Base)
+    @target = Class.new(ApplicationRecord)
     @target.table_name = 'topics'
   end
 
@@ -523,7 +523,7 @@ def test_typecast_attribute_from_select_to_true
 
   def test_raises_dangerous_attribute_error_when_defining_activerecord_method_in_model
     %w(save create_or_update).each do |method|
-      klass = Class.new ActiveRecord::Base
+      klass = Class.new ApplicationRecord
       klass.class_eval "def #{method}() 'defined #{method}' end"
       assert_raise ActiveRecord::DangerousAttributeError do
         klass.instance_method_already_implemented?(method)

activerecord/test/cases/base_test.rb

@@ -1056,7 +1056,7 @@ def test_set_table_name_symbol_converted_to_string
   end
 
   def test_quoted_table_name_after_set_table_name
-    klass = Class.new(ActiveRecord::Base)
+    klass = Class.new(ApplicationRecord)
 
     klass.table_name = "foo"
     assert_equal "foo", klass.table_name
@@ -1068,14 +1068,14 @@ def test_quoted_table_name_after_set_table_name
   end
 
   def test_set_table_name_with_inheritance
-    k = Class.new( ActiveRecord::Base )
+    k = Class.new(ApplicationRecord)
     def k.name; "Foo"; end
     def k.table_name; super + "ks"; end
     assert_equal "foosks", k.table_name
   end
 
   def test_sequence_name_with_abstract_class
-    ak = Class.new(ActiveRecord::Base)
+    ak = Class.new(ApplicationRecord)
     ak.abstract_class = true
     k = Class.new(ak)
     k.table_name = "projects"
@@ -1303,7 +1303,7 @@ def test_clear_cache!
   end
 
   def test_current_scope_is_reset
-    Object.const_set :UnloadablePost, Class.new(ActiveRecord::Base)
+    Object.const_set :UnloadablePost, Class.new(ApplicationRecord)
     UnloadablePost.send(:current_scope=, UnloadablePost.all)
 
     UnloadablePost.unloadable
@@ -1457,12 +1457,12 @@ def test_default_values_are_deeply_dupped
   end
 
   test "scoped can take a values hash" do
-    klass = Class.new(ActiveRecord::Base)
+    klass = Class.new(ApplicationRecord)
     assert_equal ['foo'], klass.all.merge!(select: 'foo').select_values
   end
 
   test "connection_handler can be overridden" do
-    klass = Class.new(ActiveRecord::Base)
+    klass = Class.new(ApplicationRecord)
     orig_handler = klass.connection_handler
     new_handler = ActiveRecord::ConnectionAdapters::ConnectionHandler.new
     thread_connection_handler = nil
@@ -1478,7 +1478,7 @@ def test_default_values_are_deeply_dupped
   end
 
   test "new threads get default the default connection handler" do
-    klass = Class.new(ActiveRecord::Base)
+    klass = Class.new(ApplicationRecord)
     orig_handler = klass.connection_handler
     handler = nil
 
@@ -1493,7 +1493,7 @@ def test_default_values_are_deeply_dupped
   end
 
   test "changing a connection handler in a main thread does not poison the other threads" do
-    klass = Class.new(ActiveRecord::Base)
+    klass = Class.new(ApplicationRecord)
     orig_handler = klass.connection_handler
     new_handler = ActiveRecord::ConnectionAdapters::ConnectionHandler.new
     after_handler = nil

activerecord/test/cases/connection_pool_test.rb

@@ -334,7 +334,7 @@ def test_pool_sets_connection_visitor
       # make sure exceptions are thrown when establish_connection
       # is called with an anonymous class
       def test_anonymous_class_exception
-        anonymous = Class.new(ActiveRecord::Base)
+        anonymous = Class.new(ApplicationRecord)
         handler = ActiveRecord::Base.connection_handler
 
         assert_raises(RuntimeError) {