Skip to content

Commit b232c51

Browse files
committed
No need to nodoc private methods
1 parent 91fa2b7 commit b232c51

File tree

9 files changed

+20
-20
lines changed

9 files changed

+20
-20
lines changed

actionview/lib/action_view/helpers/cache_helper.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ def cache_fragment_name(name = {}, skip_digest: nil, virtual_path: nil)
215215

216216
private
217217

218-
def fragment_name_with_digest(name, virtual_path) #:nodoc:
218+
def fragment_name_with_digest(name, virtual_path)
219219
virtual_path ||= @virtual_path
220220
if virtual_path
221221
name = controller.url_for(name).split("://").last if name.is_a?(Hash)
@@ -226,7 +226,7 @@ def fragment_name_with_digest(name, virtual_path) #:nodoc:
226226
end
227227
end
228228

229-
def fragment_for(name = {}, options = nil, &block) #:nodoc:
229+
def fragment_for(name = {}, options = nil, &block)
230230
if content = read_fragment_for(name, options)
231231
@cache_hit = true
232232
content
@@ -236,11 +236,11 @@ def fragment_for(name = {}, options = nil, &block) #:nodoc:
236236
end
237237
end
238238

239-
def read_fragment_for(name, options) #:nodoc:
239+
def read_fragment_for(name, options)
240240
controller.read_fragment(name, options)
241241
end
242242

243-
def write_fragment_for(name, options) #:nodoc:
243+
def write_fragment_for(name, options)
244244
# VIEW TODO: Make #capture usable outside of ERB
245245
# This dance is needed because Builder can't use capture
246246
pos = output_buffer.length

actionview/lib/action_view/helpers/tags/collection_check_boxes.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def render_component(builder)
2424
builder.check_box + builder.label
2525
end
2626

27-
def hidden_field_name #:nodoc:
27+
def hidden_field_name
2828
"#{super}[]"
2929
end
3030
end

actionview/lib/action_view/helpers/tags/collection_helpers.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def instantiate_builder(builder_class, item, value, text, html_options)
4343

4444
# Generate default options for collection helpers, such as :checked and
4545
# :disabled.
46-
def default_html_options_for_collection(item, value) #:nodoc:
46+
def default_html_options_for_collection(item, value)
4747
html_options = @html_options.dup
4848

4949
[:checked, :selected, :disabled, :readonly].each do |option|
@@ -67,11 +67,11 @@ def default_html_options_for_collection(item, value) #:nodoc:
6767
html_options
6868
end
6969

70-
def sanitize_attribute_name(value) #:nodoc:
70+
def sanitize_attribute_name(value)
7171
"#{sanitized_method_name}_#{sanitized_value(value)}"
7272
end
7373

74-
def render_collection #:nodoc:
74+
def render_collection
7575
@collection.map do |item|
7676
value = value_for_collection(item, @value_method)
7777
text = value_for_collection(item, @text_method)
@@ -82,7 +82,7 @@ def render_collection #:nodoc:
8282
end.join.html_safe
8383
end
8484

85-
def render_collection_for(builder_class, &block) #:nodoc:
85+
def render_collection_for(builder_class, &block)
8686
options = @options.stringify_keys
8787
rendered_collection = render_collection do |item, value, text, default_html_options|
8888
builder = instantiate_builder(builder_class, item, value, text, default_html_options)
@@ -103,12 +103,12 @@ def render_collection_for(builder_class, &block) #:nodoc:
103103
end
104104
end
105105

106-
def hidden_field #:nodoc:
106+
def hidden_field
107107
hidden_name = @html_options[:name] || hidden_field_name
108108
@template_object.hidden_field_tag(hidden_name, "", id: nil)
109109
end
110110

111-
def hidden_field_name #:nodoc:
111+
def hidden_field_name
112112
"#{tag_name(false, @options[:index])}"
113113
end
114114
end

actionview/lib/action_view/helpers/url_helper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ def method_tag(method)
614614
#
615615
# to_form_params({ name: 'Denmark' }, 'country')
616616
# # => [{name: 'country[name]', value: 'Denmark'}]
617-
def to_form_params(attribute, namespace = nil) # :nodoc:
617+
def to_form_params(attribute, namespace = nil)
618618
attribute = if attribute.respond_to?(:permitted?)
619619
unless attribute.permitted?
620620
raise ArgumentError, "Attempting to generate a buttom from non-sanitized request parameters!" \

actionview/lib/action_view/layouts.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ def _layout(formats)
338338
#
339339
# ==== Returns
340340
# * <tt>String</tt> - A template name
341-
def _implied_layout_name # :nodoc:
341+
def _implied_layout_name
342342
controller_path
343343
end
344344
end

actionview/lib/action_view/renderer/streaming_template_renderer.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def each(&block)
2929

3030
# This is the same logging logic as in ShowExceptions middleware.
3131
# TODO Once "exceptron" is in, refactor this piece to simply re-use exceptron.
32-
def log_error(exception) #:nodoc:
32+
def log_error(exception)
3333
logger = ActionView::Base.logger
3434
return unless logger
3535

actionview/lib/action_view/renderer/template_renderer.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def determine_template(options)
4444

4545
# Renders the given template. A string representing the layout can be
4646
# supplied as well.
47-
def render_template(template, layout_name = nil, locals = nil) #:nodoc:
47+
def render_template(template, layout_name = nil, locals = nil)
4848
view, locals = @view, locals || {}
4949

5050
render_with_layout(layout_name, locals) do |layout|
@@ -54,7 +54,7 @@ def render_template(template, layout_name = nil, locals = nil) #:nodoc:
5454
end
5555
end
5656

57-
def render_with_layout(path, locals) #:nodoc:
57+
def render_with_layout(path, locals)
5858
layout = path && find_layout(path, locals.keys, [formats.first])
5959
content = yield(layout)
6060

actionview/lib/action_view/rendering.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def rendered_format
9191

9292
# Find and render a template based on the options given.
9393
# :api: private
94-
def _render_template(options) #:nodoc:
94+
def _render_template(options)
9595
variant = options.delete(:variant)
9696
assigns = options.delete(:assigns)
9797
context = view_context
@@ -104,7 +104,7 @@ def _render_template(options) #:nodoc:
104104
end
105105

106106
# Assign the rendered format to look up context.
107-
def _process_format(format) #:nodoc:
107+
def _process_format(format)
108108
super
109109
lookup_context.formats = [format.to_sym]
110110
lookup_context.rendered_format = lookup_context.formats.first

actionview/lib/action_view/template/resolver.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ def build_path(name, prefix, partial)
177177
# always check the cache before hitting the resolver. Otherwise,
178178
# it always hits the resolver but if the key is present, check if the
179179
# resolver is fresher before returning it.
180-
def cached(key, path_info, details, locals) #:nodoc:
180+
def cached(key, path_info, details, locals)
181181
name, prefix, partial = path_info
182182
locals = locals.map(&:to_s).sort!
183183

@@ -191,7 +191,7 @@ def cached(key, path_info, details, locals) #:nodoc:
191191
end
192192

193193
# Ensures all the resolver information is set in the template.
194-
def decorate(templates, path_info, details, locals) #:nodoc:
194+
def decorate(templates, path_info, details, locals)
195195
cached = nil
196196
templates.each do |t|
197197
t.locals = locals

0 commit comments

Comments
 (0)