Schema dumping support for PostgreSQL oid type

Closes rails#27980

Author: kamipo

activerecord/CHANGELOG.md

@@ -1,4 +1,4 @@
-*   PostgreSQL: schema dumping support for PostgreSQL interval type.
+*   PostgreSQL: schema dumping support for interval and OID columns.
 
     *Ryuta Kamizono*
 

activerecord/lib/active_record/connection_adapters/postgresql/oid.rb

@@ -11,6 +11,7 @@
 require "active_record/connection_adapters/postgresql/oid/json"
 require "active_record/connection_adapters/postgresql/oid/jsonb"
 require "active_record/connection_adapters/postgresql/oid/money"
+require "active_record/connection_adapters/postgresql/oid/oid"
 require "active_record/connection_adapters/postgresql/oid/point"
 require "active_record/connection_adapters/postgresql/oid/legacy_point"
 require "active_record/connection_adapters/postgresql/oid/range"

activerecord/lib/active_record/connection_adapters/postgresql/oid/oid.rb

@@ -0,0 +1,13 @@
+module ActiveRecord
+  module ConnectionAdapters
+    module PostgreSQL
+      module OID # :nodoc:
+        class Oid < Type::Integer # :nodoc:
+          def type
+            :oid
+          end
+        end
+      end
+    end
+  end
+end

activerecord/lib/active_record/connection_adapters/postgresql/schema_definitions.rb

@@ -124,6 +124,10 @@ def numrange(*args, **options)
           args.each { |name| column(name, :numrange, options) }
         end
 
+        def oid(*args, **options)
+          args.each { |name| column(name, :oid, options) }
+        end
+
         def point(*args, **options)
           args.each { |name| column(name, :point, options) }
         end

activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb

@@ -110,6 +110,7 @@ class PostgreSQLAdapter < AbstractAdapter
         bit_varying: { name: "bit varying" },
         money:       { name: "money" },
         interval:    { name: "interval" },
+        oid:         { name: "oid" },
       }
 
       OID = PostgreSQL::OID #:nodoc:
@@ -452,7 +453,7 @@ def initialize_type_map(m)
           register_class_with_limit m, "int2", Type::Integer
           register_class_with_limit m, "int4", Type::Integer
           register_class_with_limit m, "int8", Type::Integer
-          m.alias_type "oid", "int2"
+          m.register_type "oid", OID::Oid.new
           m.register_type "float4", Type::Float.new
           m.alias_type "float8", "float4"
           m.register_type "text", Type::Text.new

activerecord/test/cases/adapters/postgresql/datatype_test.rb

@@ -33,7 +33,7 @@ def test_data_type_of_time_types
   end
 
   def test_data_type_of_oid_types
-    assert_equal :integer, @first_oid.column_for_attribute(:obj_id).type
+    assert_equal :oid, @first_oid.column_for_attribute(:obj_id).type
   end
 
   def test_time_values

activerecord/test/cases/schema_dumper_test.rb

@@ -286,6 +286,11 @@ def test_schema_dump_interval_type
       assert_match %r{t\.interval\s+"scaled_time_interval",\s+precision: 6$}, output
     end
 
+    def test_schema_dump_oid_type
+      output = dump_table_schema "postgresql_oids"
+      assert_match %r{t\.oid\s+"obj_id"$}, output
+    end
+
     if ActiveRecord::Base.connection.supports_extensions?
       def test_schema_dump_includes_extensions
         connection = ActiveRecord::Base.connection

activerecord/test/schema/postgresql_specific_schema.rb

@@ -33,11 +33,14 @@
     t.interval :scaled_time_interval, precision: 6
   end
 
-  %w(postgresql_oids postgresql_timestamp_with_zones
-      postgresql_partitioned_table postgresql_partitioned_table_parent).each do |table_name|
-    drop_table table_name, if_exists: true
+  create_table :postgresql_oids, force: true do |t|
+    t.oid :obj_id
   end
 
+  drop_table 'postgresql_timestamp_with_zones', if_exists: true
+  drop_table 'postgresql_partitioned_table', if_exists: true
+  drop_table 'postgresql_partitioned_table_parent', if_exists: true
+
   execute "DROP SEQUENCE IF EXISTS companies_nonstd_seq CASCADE"
   execute "CREATE SEQUENCE companies_nonstd_seq START 101 OWNED BY companies.id"
   execute "ALTER TABLE companies ALTER COLUMN id SET DEFAULT nextval('companies_nonstd_seq')"
@@ -49,13 +52,6 @@
     execute "SELECT setval('#{seq_name}', 100)"
   end
 
-  execute <<_SQL
-  CREATE TABLE postgresql_oids (
-    id SERIAL PRIMARY KEY,
-    obj_id OID
-  );
-_SQL
-
   execute <<_SQL
   CREATE TABLE postgresql_timestamp_with_zones (
     id SERIAL PRIMARY KEY,