Merge pull request rails#19452 from pinglamb/fix-referencing-wrong-alias-when-joining-tables-of-has-many-through-association

Fix referencing wrong aliases while joining tables of has many through association

Author: carlosantoniodasilva

activerecord/CHANGELOG.md

@@ -1,3 +1,10 @@
+*   Fix referencing wrong table aliases while joining tables of has many through
+    association (only when calling calculation methods).
+
+    Fixes #19276.
+
+    *pinglamb*
+
 *   Don't attempt to update counter caches, when the column wasn't selected.
 
     Fixes #19437.

activerecord/lib/active_record/relation/finder_methods.rb

@@ -379,7 +379,7 @@ def construct_join_dependency(joins = [])
     def construct_relation_for_association_calculations
       from = arel.froms.first
       if Arel::Table === from
-        apply_join_dependency(self, construct_join_dependency)
+        apply_join_dependency(self, construct_join_dependency(joins_values))
       else
         # FIXME: as far as I can tell, `from` will always be an Arel::Table.
         # There are no tests that test this branch, but presumably it's

activerecord/test/cases/calculations_test.rb

@@ -11,6 +11,10 @@
 require 'models/speedometer'
 require 'models/ship_part'
 require 'models/treasure'
+require 'models/developer'
+require 'models/comment'
+require 'models/rating'
+require 'models/post'
 
 class NumericData < ActiveRecord::Base
   self.table_name = 'numeric_data'
@@ -631,4 +635,11 @@ def test_grouped_calculation_with_polymorphic_relation
 
     assert_equal({ "has trinket" => part.id }, ShipPart.joins(:trinkets).group("ship_parts.name").sum(:id))
   end
+
+  def test_should_reference_correct_aliases_while_joining_tables_of_has_many_through_association
+    assert_nothing_raised ActiveRecord::StatementInvalid do
+      developer = Developer.create!(name: 'developer')
+      developer.ratings.includes(comment: :post).where(posts: { id: 1 }).count
+    end
+  end
 end