Merge pull request rails#26874 from tgxworld/fix_broadcast_logger

`Broadcast#silence` breaks custom loggers that do not include `Logg…

Author: matthewd

activesupport/lib/active_support/logger.rb

@@ -59,14 +59,14 @@ def self.broadcast(logger) # :nodoc:
         define_method(:silence) do |level = Logger::ERROR, &block|
           if logger.respond_to?(:silence)
             logger.silence(level) do
-              if respond_to?(:silence)
+              if defined?(super)
                 super(level, &block)
               else
                 block.call(self)
               end
             end
           else
-            if respond_to?(:silence)
+            if defined?(super)
               super(level, &block)
             else
               block.call(self)

activesupport/test/broadcast_logger_test.rb

@@ -69,6 +69,20 @@ class BroadcastLoggerTest < TestCase
       assert_equal ::Logger::FATAL, log2.local_level
     end
 
+    test "#silence does not break custom loggers" do
+      new_logger = FakeLogger.new
+      custom_logger = CustomLogger.new
+      custom_logger.extend(Logger.broadcast(new_logger))
+
+      custom_logger.silence do
+        custom_logger.error "from error"
+        custom_logger.unknown "from unknown"
+      end
+
+      assert_equal [[::Logger::ERROR, "from error", nil], [::Logger::UNKNOWN, "from unknown", nil]], custom_logger.adds
+      assert_equal [[::Logger::ERROR, "from error", nil], [::Logger::UNKNOWN, "from unknown", nil]], new_logger.adds
+    end
+
     test "#silence silences all loggers below the default level of ERROR" do
       logger.silence do
         logger.debug "test"
@@ -98,9 +112,7 @@ class BroadcastLoggerTest < TestCase
       assert_equal [[::Logger::FATAL, "seen", nil]], log2.adds
     end
 
-    class FakeLogger
-      include LoggerSilence
-
+    class CustomLogger
       attr_reader :adds, :closed, :chevrons
       attr_accessor :level, :progname, :formatter, :local_level
 
@@ -150,5 +162,9 @@ def close
         @closed = true
       end
     end
+
+    class FakeLogger < CustomLogger
+      include LoggerSilence
+    end
   end
 end