Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dart-lang/ecosystem
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: dart-lang/ecosystem
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: firehose-always-flutter
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 10 files changed
  • 1 contributor

Commits on Aug 7, 2024

  1. Remove the use-flutter configuration 

    Always set up the flutter SDK and use `flutter pub publish`, even for
non-flutter Dart packages. The `flutter` command can publish non-flutter
packages so no behavior changes are expected during the publish action.

Directly remove the argument, configuration, and all references
immediately. There is no plan for a deprecation/migration phase since
this only impacts CI, and the fix is trivial.
    @natebosch
    natebosch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    951dec1 View commit details
    Browse the repository at this point in the history

  2. Remove another use of the argument

    @natebosch
    natebosch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f15b1a6 View commit details
    Browse the repository at this point in the history

  3. Bump version and add changelog

    @natebosch
    natebosch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    dcf6c38 View commit details
    Browse the repository at this point in the history

  4. Remove use-flutter from the health workflow 

    The `dart` command and SDK do come with the `flutter` SDK, so it should
be OK to use the flutter SDK for health checks as well.
    @natebosch
    natebosch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f3d637e View commit details
    Browse the repository at this point in the history

  5. Retain the workflow arguments 

    This will allow backwards compatibility for the few files which are
passing it, and can be removed after they are cleaned up.
    @natebosch
    natebosch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    be67a40 View commit details
    Browse the repository at this point in the history

  6. Restore workflow argument in publish, omit from internal workflow

    @natebosch
    natebosch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    9d72b6b View commit details
    Browse the repository at this point in the history

  7. Remove another use of --use-flutter

    @natebosch
    natebosch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    71c9d83 View commit details
    Browse the repository at this point in the history
Loading