f tests

f json_api settings
f pytest.ini

Author: Boris Pleshakov

example/serializers.py

@@ -258,31 +258,6 @@ def get_first_entry(self, obj):
         return obj.entries.first()
 
 
-class CommentWithNestedFieldsSerializer(serializers.ModelSerializer):
-    entry = EntryDRFSerializers()
-
-    included_serializers = {
-        'entry': 'example.serializers.EntryDRFSerializers'
-    }
-
-    class Meta:
-        model = Comment
-        exclude = ('created_at', 'modified_at', 'author')
-        # fields = ('entry', 'body', 'author',)
-
-
-class AuthorWithNestedFieldsSerializer(serializers.ModelSerializer):
-    comments = CommentWithNestedFieldsSerializer(many=True)
-
-    included_serializers = {
-        'comments': 'example.serializers.CommentWithNestedFieldsSerializer'
-    }
-
-    class Meta:
-        model = Author
-        fields = ('name', 'email', 'comments')
-
-
 class WriterSerializer(serializers.ModelSerializer):
     included_serializers = {
         'bio': AuthorBioSerializer

example/tests/test_rendering_strategies.py

@@ -1,11 +1,14 @@
 import json
 
 import pytest
+from django.test import override_settings
+from django.utils import timezone
 
+from example.tests import TestBase
 from rest_framework_json_api import serializers, views
 from rest_framework_json_api.renderers import JSONRenderer
 
-from example.models import Author, Comment, Entry
+from example.models import Author, Comment, Entry, Blog
 
 
 # serializers
@@ -38,6 +41,31 @@ class JSONAPIMeta:
         included_resources = ('related_models',)
 
 
+class EntryDRFSerializers(serializers.ModelSerializer):
+
+    class Meta:
+        model = Entry
+        fields = ('headline', 'body_text')
+        read_only_fields = ('tags',)
+
+
+class CommentWithNestedFieldsSerializer(serializers.ModelSerializer):
+    entry = EntryDRFSerializers()
+
+    class Meta:
+        model = Comment
+        exclude = ('created_at', 'modified_at', 'author')
+        # fields = ('entry', 'body', 'author',)
+
+
+class AuthorWithNestedFieldsSerializer(serializers.ModelSerializer):
+    comments = CommentWithNestedFieldsSerializer(many=True)
+
+    class Meta:
+        model = Author
+        fields = ('name', 'email', 'comments')
+
+
 # views
 class DummyTestViewSet(views.ModelViewSet):
     queryset = Entry.objects.all()
@@ -49,6 +77,12 @@ class ReadOnlyDummyTestViewSet(views.ReadOnlyModelViewSet):
     serializer_class = DummyTestSerializer
 
 
+class AuthorWithNestedFieldsViewSet(views.ModelViewSet):
+    queryset = Author.objects.all()
+    serializer_class = AuthorWithNestedFieldsSerializer
+    resource_name = 'authors'
+
+
 def render_dummy_test_serialized_view(view_class, instance):
     serializer = view_class.serializer_class(instance=instance)
     renderer = JSONRenderer()
@@ -138,3 +172,57 @@ def test_extract_relation_instance(comment):
         field=serializer.fields['blog'], resource_instance=comment
     )
     assert got == comment.entry.blog
+
+
+class TestRenderingStrategy(TestBase):
+
+    def setUp(self):
+        super(TestRenderingStrategy, self).setUp()
+        self.blog = Blog.objects.create(name='Some Blog', tagline="It's a blog")
+        self.entry = Entry.objects.create(
+            blog=self.blog,
+            headline='headline',
+            body_text='body_text',
+            pub_date=timezone.now(),
+            mod_date=timezone.now(),
+            n_comments=0,
+            n_pingbacks=0,
+            rating=3
+        )
+
+        self.author = Author.objects.create(name='some_author', email='some_author@example.org')
+        self.entry.authors.add(self.author)
+
+        self.comment = Comment.objects.create(
+            entry=self.entry,
+            body='testing one two three',
+            author=Author.objects.first()
+        )
+
+    def test_attribute_rendering_strategy(self):
+        with override_settings(
+                JSON_API_SERIALIZE_NESTED_SERIALIZERS_AS_ATTRIBUTE=True):
+            rendered = render_dummy_test_serialized_view(AuthorWithNestedFieldsViewSet, self.author)
+            result = json.loads(rendered.decode())
+
+        expected = {
+            "data": {
+                "type": "authors",
+                "id": "1",
+                "attributes": {
+                    "name": "some_author",
+                    "email": "some_author@example.org",
+                    "comments": [
+                        {
+                            "id": 1,
+                            "entry": {
+                                'headline': 'headline',
+                                'body_text': 'body_text',
+                            },
+                            "body": "testing one two three"
+                        }
+                    ]
+                }
+            }
+        }
+        self.assertDictEqual(expected, result)

example/tests/unit/test_renderers.py

@@ -18,8 +18,7 @@
     NoFiltersetEntryViewSet,
     NonPaginatedEntryViewSet,
     ProjectTypeViewset,
-    ProjectViewset,
-    AuthorWithNestedFieldsViewSet
+    ProjectViewset
 )
 
 router = routers.DefaultRouter(trailing_slash=False)
@@ -33,7 +32,6 @@
 router.register(r'filterset-entries', FiltersetEntryViewSet, 'filterset-entry')
 router.register(r'nofilterset-entries', NoFiltersetEntryViewSet, 'nofilterset-entry')
 router.register(r'authors', AuthorViewSet)
-router.register(r'authors-nested', AuthorWithNestedFieldsViewSet, 'authors-nested')
 router.register(r'comments', CommentViewSet)
 router.register(r'companies', CompanyViewset)
 router.register(r'projects', ProjectViewset)