Skip to content

Conversation

@kojiishi
Copy link
Owner

@kojiishi kojiishi commented Feb 22, 2024

No description provided.

@kojiishi kojiishi force-pushed the kida branch 2 times, most recently from fe0f781 to 7556762 Compare February 22, 2024 08:13
@kojiishi
Copy link
Owner Author

@kidayasuo

@kojiishi kojiishi force-pushed the kida branch 7 times, most recently from 19d2912 to f14aec8 Compare February 22, 2024 12:08
302E..302F ; N # W HANGUL SINGLE DOT TONE MARK..HANGUL DOUBLE DOT TONE MARK
3005 ; N # W IDEOGRAPHIC ITERATION MARK
3006 ; W # W IDEOGRAPHIC CLOSING MARK
3007..3029 ; O # W IDEOGRAPHIC NUMBER ZERO..HANGZHOU NUMERAL NINE
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U+3007: Shouldn't this stay W, no?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we discussed this at JLReq TF. As U+3007 is used together with Han numerals, it should be W.
U+3005 should also be W.

303D..303E ; O # W PART ALTERNATION MARK..IDEOGRAPHIC VARIATION INDICATOR
3041..3096 ; W # W HIRAGANA LETTER SMALL A..HIRAGANA LETTER SMALL KE
3099..309F ; W # W COMBINING KATAKANA-HIRAGANA VOICED SOUND MARK..HIRAGANA DIGRAPH YORI
3099..309A ; N # W COMBINING KATAKANA-HIRAGANA VOICED SOUND MARK..COMBINING KATAKANA-HIRAGANA SEMI-VOICED SOUND MARK
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a regression to me, though they are Non-spacing Marks. WDYT?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How the property value works on nonspacing marks?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How the property value works on nonspacing marks?

As commented in another PR, it is applied when the code point appears alone in a paragraph. So minor edge case, but still better to be W?

3041..3096 ; W # W HIRAGANA LETTER SMALL A..HIRAGANA LETTER SMALL KE
3099..309F ; W # W COMBINING KATAKANA-HIRAGANA VOICED SOUND MARK..HIRAGANA DIGRAPH YORI
3099..309A ; N # W COMBINING KATAKANA-HIRAGANA VOICED SOUND MARK..COMBINING KATAKANA-HIRAGANA SEMI-VOICED SOUND MARK
309B..309C ; O # W KATAKANA-HIRAGANA VOICED SOUND MARK..KATAKANA-HIRAGANA SEMI-VOICED SOUND MARK
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one too.

@kojiishi kojiishi requested a review from xfq February 25, 2024 18:23
@kojiishi
Copy link
Owner Author

@kidayasuo Is this now ok to close?

@kidayasuo
Copy link
Collaborator

@kidayasuo Is this now ok to close?

Have U+3005 and 3007 been fixed? They should be W.

@kojiishi
Copy link
Owner Author

kojiishi commented Jun 10, 2024

Have U+3005 and 3007 been fixed? They should be W.

Yes, they're W now. Please see the current data file.

@kojiishi
Copy link
Owner Author

Closing as per the discussions above and no further feedback.

@kojiishi kojiishi closed this Jun 27, 2024
@kojiishi kojiishi deleted the kida branch June 30, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants