[Plugin] refactor enable/disable.

Signed-off-by: Eric Wang <skygragon@gmail.com>

Author: skygragon

lib/commands/plugin.js

@@ -82,19 +82,9 @@ cmd.handler = function(argv) {
   const fullpath = h.getPluginFile(plugin.file);
 
   if (argv.enable) {
-    if (plugin.enabled) return;
-    const newname = h.getPluginFile(plugin.file.substr(1));
-
-    fs.rename(fullpath, newname, function(e) {
-      if (e) log.error(e.message);
-    });
+    plugin.enable(true);
   } else if (argv.disable) {
-    if (!plugin.enabled) return;
-    const newname = h.getPluginFile('.' + plugin.file);
-
-    fs.rename(fullpath, newname, function(e) {
-      if (e) log.error(e.message);
-    });
+    plugin.enable(false);
   } else if (argv.delete) {
     fs.unlink(fullpath, function(e) {
       if (e) log.error(e.message);

lib/plugin.js

@@ -34,6 +34,22 @@ Plugin.prototype.setNext = function(next) {
   this.next = next;
 };
 
+Plugin.prototype.setFile = function(file) {
+  this.file = file;
+  this.enabled = (file[0] !== '.');
+};
+
+Plugin.prototype.enable = function(enabled) {
+  if (this.enabled === enabled) return;
+  const newfile = enabled ? this.file.substr(1) : '.' + this.file;
+  try {
+    fs.renameSync(h.getPluginFile(this.file), h.getPluginFile(newfile));
+    this.setFile(newfile);
+  } catch(e) {
+    log.error(e);
+  }
+};
+
 Plugin.prototype.install = function(cb) {
   if (this.deps.length === 0) return cb();
 
@@ -56,9 +72,7 @@ Plugin.init = function(head) {
     const p = f.data;
     if (!p) continue;
 
-    p.file = f.file;
-    if (f.name[0] === '.') p.enabled = false;
-
+    p.setFile(f.file);
     log.trace('found plugin: ' + p.name + '=' + p.ver);
     if (p.enabled) {
       p.init();

test/test_plugin.js

@@ -29,9 +29,9 @@ describe('plugin', function() {
 
       h.getCodeDirData = function() {
         return [
-          {name: 'cache', data: cache},
-          {name: '.leetcode', data: leetcode},  // disabled
-          {name: 'retry', data: retry},
+          {name: 'cache', data: cache, file: 'cache.js'},
+          {name: 'leetcode', data: leetcode, file: '.leetcode.js'},  // disabled
+          {name: 'retry', data: retry, file: 'retry.js'},
           {name: 'bad', data: null}
         ];
       };
@@ -122,4 +122,33 @@ describe('plugin', function() {
       });
     });
   });
+
+  describe('#enable', function() {
+    const file = path.resolve('./tmp/leetcode.js');
+
+    function clean() {
+      if (fs.existsSync(file)) fs.unlinkSync(file);
+      h.getPluginFile = () => file;
+    }
+
+    beforeEach(clean);
+    after(clean);
+
+    it('should ok', function() {
+      const p = new Plugin(0, 'Leetcode', '2.0', '');
+      assert.equal(p.enabled, true);
+
+      p.setFile('.leetcode.js');
+      fs.writeFileSync(file, '');
+      assert.equal(p.enabled, false);
+      assert.equal(p.file, '.leetcode.js');
+
+      p.enable(false);
+      assert.equal(p.enabled, false);
+      assert.equal(p.file, '.leetcode.js');
+      p.enable(true);
+      assert.equal(p.enabled, true);
+      assert.equal(p.file, 'leetcode.js');
+    });
+  }); // #enable
 });