-
Notifications
You must be signed in to change notification settings - Fork 36.5k
Description
For a long time VS Code has preferences for light and dark modes, as well as automatic switching based on the current system theme. Ever since those were added, I started using, as my system is already configured to switch themes and brightness automatically based on sunrise/sunset times, which greatly reduces eye strain. However, what always confused me, is that there were never such settings for the file icon theme.
It's obvious that there cannot be a universal colourful theme that will suit light and dark modes. Using file icon theme that is designed for dark mode in light mode (and the opposite) will make icons unreadable, if at all visible. So it's only fair that each mode would have a specific file icon assigned to it. This is why editors like Zed provide preferences for that.
However, I was beyond astonished to see how VS Code developer simply dismissed this glaring accessibility issue as something that can be solved by the extension. Of course, you can still switch themes manually every time and remember their names by hand, but this is just unnecessary friction. It's also really frustrating, because for some reason VS Code team believes that I absolutely need Copilot to install it every time I update VS Code, but somehow two settings to fix actual issue is an unnecessary bloat, even though there is already similar functionality to that.
I sincerely ask you to reconsider your stance and adopting or re-implementing an existing PR to add those settings: #232336. Otherwise, please provide a more reasonable explanation why this functionality cannot be accepted and must be implemented by a third-party extension, besides just "naah, I don't feel like it", because that's not a good reason at all.
Previous issue: #185727