Add match media change listener in browser ts #143287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
reviewed
Feb 17, 2022
src/vs/base/browser/dom.ts
Outdated
| import { withNullAsUndefined } from 'vs/base/common/types'; | ||
| import { URI } from 'vs/base/common/uri'; | ||
|
|
||
| export { addMatchMediaChangeListener } from 'vs/base/browser/browser'; |
Contributor
Author
There was a problem hiding this comment.
As some things import addMatchMediaChangeListener from dom.ts.
If you prefer I could update all the imports to point at browser.ts?
Contributor
Author
There was a problem hiding this comment.
Done, sorry for the delay
bpasero
approved these changes
Feb 25, 2022
Member
bpasero
left a comment
There was a problem hiding this comment.
LGTM. Arguably even though isStandalone is now dynamic, there are still a few places where we statically call this method on startup and then fail to reconcile the change. But I think your scenario should be covered.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #143197
Logic based on if the window is standalone should be based on if it is currently standalone, rather than if it was standalone when VS Code was started.
This change also moves
addMatchMediaChangeListenerfrom browser.ts to dom.ts so that it can be used in dom.ts without creating a circular dependency.