Skip to content

Fix infinite recursion in getDirectoryHandle #145972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Fix infinite recursion in getDirectoryHandle #145972

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dc5b64
Fix infinite recursion in `getDirectoryHandle`
kkocdko Mar 24, 2022
43e75f6
:lipstick:
bpasero Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/vs/platform/files/browser/htmlFileSystemProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,12 @@ export class HTMLFileSystemProvider implements IFileSystemProviderWithFileReadWr
return handle;
}

const parent = await this.getDirectoryHandle(this.extUri.dirname(resource));
const parentUri = this.extUri.dirname(resource);
if (this.extUri.isEqual(parentUri, resource)) {
return undefined; // return when root is reached to prevent infinite recursion
}

const parent = await this.getDirectoryHandle(parentUri);

try {
return await parent?.getDirectoryHandle(extUri.basename(resource));
Expand Down