Skip to content

Commit 5653458

Browse files
authored
Merge pull request #20013 from calixteman/fix_annotation_tabindex
Make annotations focusable just after the text layer
2 parents 3baea2f + 0d995fa commit 5653458

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

src/display/annotation_layer.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ import { ColorConverters } from "../shared/scripting_utils.js";
4343
import { DOMSVGFactory } from "./svg_factory.js";
4444
import { XfaLayer } from "./xfa_layer.js";
4545

46-
const DEFAULT_TAB_INDEX = 1000;
4746
const DEFAULT_FONT_SIZE = 9;
4847
const GetElementsByNameSet = new WeakSet();
4948

@@ -263,7 +262,7 @@ class AnnotationElement {
263262
const container = document.createElement("section");
264263
container.setAttribute("data-annotation-id", data.id);
265264
if (!(this instanceof WidgetAnnotationElement)) {
266-
container.tabIndex = DEFAULT_TAB_INDEX;
265+
container.tabIndex = 0;
267266
}
268267
const { style } = container;
269268

@@ -1293,7 +1292,7 @@ class TextWidgetAnnotationElement extends WidgetAnnotationElement {
12931292

12941293
element.disabled = this.data.readOnly;
12951294
element.name = this.data.fieldName;
1296-
element.tabIndex = DEFAULT_TAB_INDEX;
1295+
element.tabIndex = 0;
12971296

12981297
this._setRequired(element, this.data.required);
12991298

@@ -1613,7 +1612,7 @@ class CheckboxWidgetAnnotationElement extends WidgetAnnotationElement {
16131612
element.setAttribute("checked", true);
16141613
}
16151614
element.setAttribute("exportValue", data.exportValue);
1616-
element.tabIndex = DEFAULT_TAB_INDEX;
1615+
element.tabIndex = 0;
16171616

16181617
element.addEventListener("change", event => {
16191618
const { name, checked } = event.target;
@@ -1713,7 +1712,7 @@ class RadioButtonWidgetAnnotationElement extends WidgetAnnotationElement {
17131712
if (value) {
17141713
element.setAttribute("checked", true);
17151714
}
1716-
element.tabIndex = DEFAULT_TAB_INDEX;
1715+
element.tabIndex = 0;
17171716

17181717
element.addEventListener("change", event => {
17191718
const { name, checked } = event.target;
@@ -1820,7 +1819,7 @@ class ChoiceWidgetAnnotationElement extends WidgetAnnotationElement {
18201819
selectElement.disabled = this.data.readOnly;
18211820
this._setRequired(selectElement, this.data.required);
18221821
selectElement.name = this.data.fieldName;
1823-
selectElement.tabIndex = DEFAULT_TAB_INDEX;
1822+
selectElement.tabIndex = 0;
18241823

18251824
let addAnEmptyEntry = this.data.combo && this.data.options.length > 0;
18261825

0 commit comments

Comments
 (0)