-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Lint and format the HTML in using Prettier #20447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The linter found some issues in viewer.html with </input> which isn't required and a missing closing div in test/resources/reftest-analyzer.html. The HTML can now be nicely formatted. In order to not break the build for mozilla-central, the preprocessor has been fixed in order to take into account the white spaces at the beginning of a comment line. And finally, make .prettierrc (which is supposed to be either json or yaml) itself lintable.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/396f7ec42a759cb/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6d18743154329fd/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6d18743154329fd/output.txt Total script time: 39.60 mins
Image differences available at: http://54.241.84.105:8877/6d18743154329fd/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/396f7ec42a759cb/output.txt Total script time: 75.80 mins
Image differences available at: http://54.193.163.58:8877/396f7ec42a759cb/reftest-analyzer.html#web=eq.log |
|
Nice work; thank you for bringing some much-needed consistency in this area! |
Don't use firstChild/lastChild when getting elements (follow-up of #20447)
The linter found some issues in viewer.html with which isn't required and a missing closing div in test/resources/reftest-analyzer.html.
The HTML can now be nicely formatted. In order to not break the build for mozilla-central, the preprocessor has been fixed in order to take into account the white spaces at the beginning of a comment line.
And finally, make .prettierrc (which is supposed to be either json or yaml) itself lintable.