implementation "androidx.browser:browser:1.8.0" #16004
Open
+17
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
duvvuvenkataramana
commented
Nov 25, 2025
- Tests written, or not not needed
Signed-off-by: duvvuvenkataramana <venkataramana2048@gmail.com>
Contributor
Author
|
@AndyScherzinger Review this and merge |
AndyScherzinger
requested changes
Nov 25, 2025
Member
AndyScherzinger
left a comment
There was a problem hiding this comment.
@duvvuvenkataramana see CI checks, this doesn't compile, see for example https://github.com/nextcloud/android/actions/runs/19671017003/job/56360672919?pr=16004#step:5:1061
Again, this feels fully vibe coded with a misleading PR title and code that doesn't event compile, hence no quality assurance, neither manual not automated even failing to compile and run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.