Cleanup

Author: sebastianbergmann

src/Differ.php

@@ -247,32 +247,36 @@ public function diffToArray($from, $to, LongestCommonSubsequence $lcs = null)
     }
 
     /**
-     * @param  array|string $from
-     * @param  array|string $to
+     * @param  array $from
+     * @param  array $to
      * @return LongestCommonSubsequence
      */
-    private function selectLcsImplementation($from, $to)
+    private function selectLcsImplementation(array $from, array $to)
     {
-        // We don't want to use the time efficient implementation if it's memory
+        // We do not want to use the time-efficient implementation if its memory
         // footprint will probably exceed this value. Note that the footprint
         // calculation is only an estimation for the matrix and the LCS method
         // will typically allocate a bit more memory than this.
-        $memoryLimit = 100 * 1024*1024;
+        $memoryLimit = 100 * 1024 * 1024;
+
         if ($this->calculateEstimatedFootprint($from, $to) > $memoryLimit) {
-          return new MemoryEfficientImplementation;
+            return new MemoryEfficientImplementation;
         }
+
         return new TimeEfficientImplementation;
     }
 
     /**
      * Calculates the estimated memory footprint for the DP-based method.
      *
-     * @param type $from
-     * @param type $to
+     * @param  array $from
+     * @param  array $to
+     * @return integer
      */
-    private function calculateEstimatedFootprint($from, $to)
+    private function calculateEstimatedFootprint(array $from, array $to)
     {
         $itemSize = PHP_INT_SIZE == 4 ? 76 : 144;
+
         return $itemSize * pow(min(count($from), count($to)), 2);
     }
 }

src/LCS/LongestCommonSubsequence.php

@@ -64,4 +64,4 @@ interface LongestCommonSubsequence
      * @return array
      */
     public function calculate(array $from, array $to);
-}
+}

src/LCS/MemoryEfficientLongestCommonSubsequenceImplementation.php

@@ -85,7 +85,7 @@ public function calculate(array $from, array $to)
             $jMax      = 0;
             $max       = 0;
 
-            for($j = 0; $j <= $cTo; $j++) {
+            for ($j = 0; $j <= $cTo; $j++) {
                 $m = $llB[$j] + $llE[$cTo - $j];
 
                 if ($m >= $max) {
@@ -115,7 +115,7 @@ private function length(array $from, array $to)
         $cFrom   = count($from);
         $cTo     = count($to);
 
-        for($i = 0; $i < $cFrom; $i++) {
+        for ($i = 0; $i < $cFrom; $i++) {
             $prev = $current;
 
             for ($j = 0; $j < $cTo; $j++) {
@@ -129,4 +129,4 @@ private function length(array $from, array $to)
 
         return $current;
     }
-}
+}

src/LCS/TimeEfficientLongestCommonSubsequenceImplementation.php

@@ -105,4 +105,4 @@ public function calculate(array $from, array $to)
 
         return $common;
     }
-}
+}