multi client configuration

Author: ASKozienko

pkg/enqueue-bundle/DependencyInjection/Configuration.php

@@ -24,32 +24,6 @@ public function getConfigTreeBuilder(): TreeBuilder
     {
         $tb = new TreeBuilder();
         $rootNode = $tb->root('enqueue');
-        $rootNode
-            ->beforeNormalization()
-            ->always(function ($value) {
-                if (empty($value)) {
-                    return [
-                        'default' => [
-                            'transport' => [
-                                'dsn' => 'null:',
-                            ],
-                        ],
-                    ];
-                }
-
-                if (is_string($value)) {
-                    return [
-                        'default' => [
-                            'transport' => [
-                                'dsn' => $value,
-                            ],
-                        ],
-                    ];
-                }
-
-                return $value;
-            })
-        ;
 
         $rootNode
             ->requiresAtLeastOneElement()

pkg/enqueue-bundle/Tests/Unit/DependencyInjection/ConfigurationTest.php

@@ -28,48 +28,6 @@ public function testCouldBeConstructedWithDebugAsArgument()
         new Configuration(true);
     }
 
-    public function testShouldProcessNullAsDefaultNullTransport()
-    {
-        $configuration = new Configuration(true);
-
-        $processor = new Processor();
-        $config = $processor->processConfiguration($configuration, [null]);
-
-        $this->assertConfigEquals([
-            'default' => [
-                'transport' => ['dsn' => 'null:'],
-            ],
-        ], $config);
-    }
-
-    public function testShouldProcessStringAsDefaultDsnTransport()
-    {
-        $configuration = new Configuration(true);
-
-        $processor = new Processor();
-        $config = $processor->processConfiguration($configuration, ['foo://bar?option=val']);
-
-        $this->assertConfigEquals([
-            'default' => [
-                'transport' => ['dsn' => 'foo://bar?option=val'],
-            ],
-        ], $config);
-    }
-
-    public function testShouldProcessEmptyArrayAsDefaultNullTransport()
-    {
-        $configuration = new Configuration(true);
-
-        $processor = new Processor();
-        $config = $processor->processConfiguration($configuration, [[]]);
-
-        $this->assertConfigEquals([
-            'default' => [
-                'transport' => ['dsn' => 'null:'],
-            ],
-        ], $config);
-    }
-
     public function testShouldProcessSeveralTransports()
     {
         $configuration = new Configuration(true);
@@ -118,32 +76,6 @@ public function testTransportFactoryShouldValidateEachTransportAccordingToItsRul
         ]);
     }
 
-    public function testShouldUseDefaultConfigurationIfNothingIsConfiguredAtAll()
-    {
-        $configuration = new Configuration(true);
-
-        $processor = new Processor();
-        $config = $processor->processConfiguration($configuration, [[]]);
-
-        $this->assertEquals([
-            'default' => [
-                'transport' => ['dsn' => 'null:'],
-                'consumption' => [
-                    'receive_timeout' => 10000,
-                ],
-//                'job' => false,
-//                'async_events' => ['enabled' => false],
-                'async_commands' => ['enabled' => false],
-                'extensions' => [
-                    'doctrine_ping_connection_extension' => false,
-                    'doctrine_clear_identity_map_extension' => false,
-                    'signal_extension' => function_exists('pcntl_signal_dispatch'),
-                    'reply_extension' => true,
-                ],
-            ],
-        ], $config);
-    }
-
     public function testShouldSetDefaultConfigurationForClient()
     {
         $configuration = new Configuration(true);
@@ -264,7 +196,11 @@ public function testDoctrinePingConnectionExtensionShouldBeDisabledByDefault()
         $configuration = new Configuration(true);
 
         $processor = new Processor();
-        $config = $processor->processConfiguration($configuration, [[]]);
+        $config = $processor->processConfiguration($configuration, [[
+            'default' => [
+                'transport' => null,
+            ]
+        ]]);
 
         $this->assertArraySubset([
             'default' => [
@@ -303,7 +239,11 @@ public function testDoctrineClearIdentityMapExtensionShouldBeDisabledByDefault()
         $configuration = new Configuration(true);
 
         $processor = new Processor();
-        $config = $processor->processConfiguration($configuration, [[]]);
+        $config = $processor->processConfiguration($configuration, [[
+            'default' => [
+                'transport' => null,
+            ]
+        ]]);
 
         $this->assertArraySubset([
             'default' => [