From dcca05d207aee1527f5c6d9575dc4c453a8a16e4 Mon Sep 17 00:00:00 2001 From: Arne Blankerts Date: Sun, 5 Jan 2014 22:34:19 +0100 Subject: [PATCH 1/2] Add Status code translation from PHPUnit_Runner_BaseTestRunner constants to XML Coverage Report --- PHP/CodeCoverage/Report/XML/Tests.php | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/PHP/CodeCoverage/Report/XML/Tests.php b/PHP/CodeCoverage/Report/XML/Tests.php index 1a85fac84..d608e4abc 100644 --- a/PHP/CodeCoverage/Report/XML/Tests.php +++ b/PHP/CodeCoverage/Report/XML/Tests.php @@ -56,6 +56,15 @@ class PHP_CodeCoverage_Report_XML_Tests { private $contextNode; + private $codeMap = array( + PHPUnit_Runner_BaseTestRunner::STATUS_PASSED => 'PASSED', + PHPUnit_Runner_BaseTestRunner::STATUS_SKIPPED => 'SKIPPED', + PHPUnit_Runner_BaseTestRunner::STATUS_INCOMPLETE => 'INCOMPLETE', + PHPUnit_Runner_BaseTestRunner::STATUS_FAILURE => 'FAILURE', + PHPUnit_Runner_BaseTestRunner::STATUS_ERROR => 'ERROR', + PHPUnit_Runner_BaseTestRunner::STATUS_RISKY => 'RISKY' + ); + public function __construct(DOMElement $context) { $this->contextNode = $context; @@ -68,8 +77,9 @@ public function addTest($test, $result) 'http://schema.phpunit.de/coverage/1.0', 'test' ) ); - $node->setAttribute('name', $test); - $node->setAttribute('result', $result); + $node->setAttribute('result', (int)$result); + $node->setAttribute('status', $this->codeMap[(int)$result]); + } } From ab3b1e9c0b1bb30044ff9554c233c4b0d06e4550 Mon Sep 17 00:00:00 2001 From: Arne Blankerts Date: Sun, 5 Jan 2014 22:54:14 +0100 Subject: [PATCH 2/2] Remove dependency on PHPUnit_Runner_BaseTestRunner --- PHP/CodeCoverage/Report/XML/Tests.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/PHP/CodeCoverage/Report/XML/Tests.php b/PHP/CodeCoverage/Report/XML/Tests.php index d608e4abc..99c6e0a10 100644 --- a/PHP/CodeCoverage/Report/XML/Tests.php +++ b/PHP/CodeCoverage/Report/XML/Tests.php @@ -57,12 +57,12 @@ class PHP_CodeCoverage_Report_XML_Tests private $contextNode; private $codeMap = array( - PHPUnit_Runner_BaseTestRunner::STATUS_PASSED => 'PASSED', - PHPUnit_Runner_BaseTestRunner::STATUS_SKIPPED => 'SKIPPED', - PHPUnit_Runner_BaseTestRunner::STATUS_INCOMPLETE => 'INCOMPLETE', - PHPUnit_Runner_BaseTestRunner::STATUS_FAILURE => 'FAILURE', - PHPUnit_Runner_BaseTestRunner::STATUS_ERROR => 'ERROR', - PHPUnit_Runner_BaseTestRunner::STATUS_RISKY => 'RISKY' + 0 => 'PASSED', // PHPUnit_Runner_BaseTestRunner::STATUS_PASSED + 1 => 'SKIPPED', // PHPUnit_Runner_BaseTestRunner::STATUS_SKIPPED + 2 => 'INCOMPLETE', // PHPUnit_Runner_BaseTestRunner::STATUS_INCOMPLETE + 3 => 'FAILURE', // PHPUnit_Runner_BaseTestRunner::STATUS_FAILURE + 4 => 'ERROR', // PHPUnit_Runner_BaseTestRunner::STATUS_ERROR + 5 => 'RISKY' // PHPUnit_Runner_BaseTestRunner::STATUS_RISKY ); public function __construct(DOMElement $context)