You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm using this with neovim. I use multiple SQL dialects, which lead me to the following situation: sometimes I'm working on a directory that does not use Postgres and the server starts anyway. From what I can tell, the server is not really useful in this scenario, so perhaps it shouldn't be started at all? Please, let me know if that's not the case.
The server attaches because the default neovim configuration does not enable workspace_required (previously, this setting was called single_file_support, which meant the opposite). Locally, I can override this configuration and only have the server attaching if neovim finds a postgres-language-server.jsonc. However, I was wondering if it makes sense to update the default configuration for neovim, so that others can "benefit" from this as well.
So, my question is: should the server attach to "single files" (i.e., even if a postgres-language-server.jsonc is not found), which is the current behavior with neovim, or should it only attach if a postgres-language-server.jsonc is found?
I traced down the original commit that initially set single_file_support, I'm not sure if it takes into account the scenario I described.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Hello,
I'm using this with neovim. I use multiple SQL dialects, which lead me to the following situation: sometimes I'm working on a directory that does not use Postgres and the server starts anyway. From what I can tell, the server is not really useful in this scenario, so perhaps it shouldn't be started at all? Please, let me know if that's not the case.
The server attaches because the default neovim configuration does not enable
workspace_required(previously, this setting was calledsingle_file_support, which meant the opposite). Locally, I can override this configuration and only have the server attaching if neovim finds apostgres-language-server.jsonc. However, I was wondering if it makes sense to update the default configuration for neovim, so that others can "benefit" from this as well.So, my question is: should the server attach to "single files" (i.e., even if a
postgres-language-server.jsoncis not found), which is the current behavior with neovim, or should it only attach if apostgres-language-server.jsoncis found?I traced down the original commit that initially set
single_file_support, I'm not sure if it takes into account the scenario I described.Beta Was this translation helpful? Give feedback.
All reactions