matplotlib-devel Mailing List for matplotlib

On Wed, 13 Apr 2005, John Hunter wrote:

> I think your diff had improper line wrapping.  Could you resent it or
> the entire file as an attachment?

Here's the attachment.

--Michael

>>>>> "Michael" == Michael Brady <mb...@jp...> writes:

    Michael> Hi John, I'm one the developers at JPL who worked on the
    Michael> Qt backend.  Below are diffs for a couple of minor mods
    Michael> to the Qt backend.  They:

Hi Michael, 

I think your diff had improper line wrapping.  Could you resent it or
the entire file as an attachment?

Thanks,
JDH

Hi John,

I'm one the developers at JPL who worked on the Qt backend.  Below are 
diffs for a couple of minor mods to the Qt backend.  They:

1) fix a bug where keyboard input was grabbed by the figure
    and not released.
2) turn on cursor changes.
3) clean up a typo and commented-out print statement.

Please add them to backend_qt.py at your convenience.

Thanks,

Michael

========================================================================
  Michael Brady
  Jet Propulsion Laboratory (M/S 301-140L)
  4800 Oak Grove Drive
  Pasadena, CA  91109 
========================================================================

--- 
/home/mbrady/matplotlib-cvs/matplotlib/lib/matplotlib/backends/backend_qt.py 
2005-03-01 07:53:17.000000000 -0800
+++ backend_qt.py	2005-04-13 11:32:11.000000000 -0700
@@ -15,7 +15,7 @@
  from matplotlib.mathtext import math_parse_s_ft2font
  import qt

-backend_version = "0.9"
+backend_version = "0.9.1"
  def fn_name(): return sys._getframe(1).f_code.co_name

  DEBUG = False
@@ -88,10 +88,9 @@
          x = event.pos().x()
          # flipy so y=0 is bottom of canvas
          y = self.figure.bbox.height() - event.pos().y()
-        #print 'event.button()', event.button()
          button = self.buttond[event.button()]
          FigureCanvasBase.button_press_event( self, x, y, button )
-        if DEBUG: print 'button pressed'
+        if DEBUG: print 'button pressed:', event.button()

      def mouseMoveEvent( self, event ):
          x = event.x()
@@ -104,7 +103,7 @@
          x = event.x()
          # flipy so y=0 is bottom of canvas
          y = self.figure.bbox.height() - event.y()
-        button = button = self.buttond[event.button()]
+        button = self.buttond[event.button()]
          FigureCanvasBase.button_release_event( self, x, y, button )
          if DEBUG: print 'button released'
          self.draw()
@@ -147,7 +146,8 @@

          self.canvas.reparent( self.window, qt.QPoint( 0, 0 ) )
          # Give the keyboard focus to the figure instead of the manager
-        self.canvas.grabKeyboard()
+        self.canvas.setFocusPolicy( qt.QWidget.ClickFocus )
+        self.canvas.setFocus()
          self.window.setCaption( "Figure %d" % num )
          self.window.setCentralWidget( self.canvas )

@@ -227,8 +227,8 @@

      def set_cursor( self, cursor ):
          if DEBUG: print 'Set cursor' , cursor
-        #qt.QApplication.restoreOverrideCursor()
-        #qt.QApplication.setOverrideCursor( qt.QCursor( cursord[cursor] ) 
)
+        qt.QApplication.restoreOverrideCursor()
+        qt.QApplication.setOverrideCursor( qt.QCursor( cursord[cursor] ) 
)

      def draw_rubberband( self, event, x0, y0, x1, y1 ):
          height = self.canvas.figure.bbox.height()
@@ -242,12 +242,9 @@
          self.canvas.drawRectangle( rect )

      def save_figure( self ):
-        self.canvas.releaseKeyboard()
          fname = qt.QFileDialog.getSaveFileName()
-
          if fname:
              self.canvas.print_figure( fname.latin1() )
-        self.canvas.grabKeyboard()

  # set icon used when windows are minimized
  try:

>>>>> "Andrew" == Andrew Straw <str...@as...> writes:

    Andrew> Hi All, On my debian sarge (testing) box, I'm getting the
    Andrew> following error with the latest CVS code, WXAgg backend
    Andrew> and numerix = numarray.  I don't get a similar error with
    Andrew> GTKAgg, so I think it has to do with the WX backend.  My
    Andrew> thinking is that we should fix this before the 0.80
    Andrew> release.  Unfortunately, I don't have time to delve in
    Andrew> right now.

See the release notes <wink>

  Incorporated Werner's wx patch -- wx backend should be compatible
  with wxpython2.4 and recent versions of 2.5. Some early versions of
  wxpython 2.5 will not work because there was a temporary change in
  the dc API that was rolled back to make it 2.4 compliant

So basically my understanding is that early versions of wx 2.5 made
some changes to the 2.4 API, decided they were unwise, and unrolled
them to make them compatible with 2.4.

The error you are getting is one of these changes.

If you apt-get upgrade your wx on debian sarge, what wx version do you
get, and does the problem go away?

We do have the option of unrolling the namespace change Werner made
for a while, but this seems like a maintenance hassle to have to
reapply it later.  I open to suggestions.

JDH

Hi All,

On my debian sarge (testing) box, I'm getting the following error with 
the latest CVS code, WXAgg backend and numerix = numarray.  I don't get 
a similar error with GTKAgg, so I think it has to do with the WX 
backend.  My thinking is that we should fix this before the 0.80 
release.  Unfortunately, I don't have time to delve in right now.

$ python simple_plot.py
Traceback (most recent call last):
  File 
"/usr/lib/python2.3/site-packages/matplotlib/backends/backend_wx.py", 
line 1067, in _onSize
    self.draw()
  File 
"/usr/lib/python2.3/site-packages/matplotlib/backends/backend_wxagg.py", 
line 61, in draw
    self.gui_repaint()
  File 
"/usr/lib/python2.3/site-packages/matplotlib/backends/backend_wx.py", 
line 897, in gui_repaint
    drawDC.DrawBitmap(self.bitmap, 0, 0)
  File 
"/home/ron/devel/debian/wxwindows/2.5.1.1-debs/wxwidgets2.5-2.5.1.1/wxPython/../debian/libwxgtk2.5-python/usr/lib/python2.3/site-packages/wx/gdi.py", 
line 2397, in DrawBitmap
TypeError: Expected a 2-tuple of integers or a wxPoint object.
Traceback (most recent call last):
  File "simple_plot.py", line 8, in ?
    plot(t, s)
  File "/usr/lib/python2.3/site-packages/matplotlib/pylab.py", line 
1900, in plot
    draw_if_interactive()
  File 
"/usr/lib/python2.3/site-packages/matplotlib/backends/backend_wx.py", 
line 1161, in draw_if_interactive
    figManager.canvas.draw()
  File 
"/usr/lib/python2.3/site-packages/matplotlib/backends/backend_wxagg.py", 
line 61, in draw
    self.gui_repaint()
  File 
"/usr/lib/python2.3/site-packages/matplotlib/backends/backend_wx.py", 
line 897, in gui_repaint
    drawDC.DrawBitmap(self.bitmap, 0, 0)
  File 
"/home/ron/devel/debian/wxwindows/2.5.1.1-debs/wxwidgets2.5-2.5.1.1/wxPython/../debian/libwxgtk2.5-python/usr/lib/python2.3/site-packages/wx/gdi.py", 
line 2397, in DrawBitmap
TypeError: Expected a 2-tuple of integers or a wxPoint object.