matplotlib-devel Mailing List for matplotlib

Jochen Voss schrieb:
> Hello Steve,
> 
> On Wed, Nov 17, 2004 at 11:00:32PM +0800, Steve Chaplin wrote:
> 
>>I don't think failure to save a file should be a fatal error.
>>Perhaps PS/SVG print_figure() could raise an exception for the GUI
>>backend to catch so it can popup an error message and continue.
> 
> Even now you can probably (not tried) catch the SystemExit
> exception and prevent the program from aborting.
> Do you think raising SystemExit like
> 
>     raise SystemExit("error while writing file: permission denied")
> 
> would be good enough.  The GUI frontend could catch SystemExit,
> check whether the associated value is a string, and then display
> this string in an error message box.
> 
> What do you think?

Bad design.  Doing exception analysis based on string matching for the message 
is very brittle.  A single change in capitalization of the message can break 
things down the road.

It's _far_ better to either:

1. have the ps/svg backends do whatever cleanup they want, and then reraise 
the original exception unchanged

2. or simply make a matplotlib.SaveError exception which can be explicitly 
caught based on class matching, which is the preferred python way of doing this.

Best,

f

Hello Steve,

On Wed, Nov 17, 2004 at 11:00:32PM +0800, Steve Chaplin wrote:
> I don't think failure to save a file should be a fatal error.
> Perhaps PS/SVG print_figure() could raise an exception for the GUI
> backend to catch so it can popup an error message and continue.
Even now you can probably (not tried) catch the SystemExit
exception and prevent the program from aborting.
Do you think raising SystemExit like

    raise SystemExit("error while writing file: permission denied")

would be good enough.  The GUI frontend could catch SystemExit,
check whether the associated value is a string, and then display
this string in an error message box.

What do you think?

Jochen
--=20
http://seehuhn.de/

I've noticed a problem as follows:

You run a GUI backend (GTK, GTKAgg etc) and want to save a figure.
You select the toolbar save button and type in a .ps or .svg filename
and select save.
The GUI backend switches to the PS/SVG backend to save the file.
If there is a problem saving the file, for example you do not have write
permission to the directory, PS/SVG backends will kill your GUI
application with sys.exit()

I don't think failure to save a file should be a fatal error.
Perhaps PS/SVG print_figure() could raise an exception for the GUI
backend to catch so it can popup an error message and continue.

Steve

Hi there,

again a few patches, mostly independent but somewhat interconnected:

axes-kwargs:
	a general cleanup of the code in axes.py - in several places, kwargs was 
handled inconsistently, ignoring surplus arguments. I went through all uses 
of kwargs and made sure that every argument is either used or reported as 
error

legend-fontsize:
	a tiny hack to make Legend respect the FONTSIZE parameter correctly. (up to 
now, it was plainly ignored)

legend-kwargs:
	have Legend.__init__ respect a bunch of kwargs, overriding the global 
defaults. Also Axes.legend passes these arguments through correctly

Ciao,
Norbert

-- 
_________________________________________Norbert Nemec
         Bernhardstr. 2 ... D-93053 Regensburg
     Tel: 0941 - 2009638 ... Mobil: 0179 - 7475199
           eMail: <No...@Ne...>