matplotlib-devel Mailing List for matplotlib

Hi John,

I've uploaded some new files to sourceforge.

On May 26, 2005, at 7:34 PM, John Hunter wrote:
> My only suggestions
> are: 1) move the dash text class to the text module rather than the 
> axis
> module (where it seems to belong since it is a general purpose
> connector between a text instance and a point), and

Done. I also slightly modified axes.py to facilitate providing
your suggestion 2).

> 2) provide an example
> which uses a generic text instance in addition to the one you provided
> using a tick label text instance.

Please see the new example, which I'm attaching below.
As I note in the script which generated the plot, the various
rotations are meant to show the possibilities, rather than
for visual appeal.

> As for the alignment problems (in agg or ps at least), they may be a
> result of sf bugs #1194018 and #1177396.

I also think the current rendering when separate rotations for
the text and the dash are specified is suboptimal (I show
examples of this in the new example plot), but the current code
satisfies my immediate use case, so I'm hoping that if/as this
extension gets incorporated into the matplotlib codebase,
others will find that improving the current rotation/transformation
logic will be an itch that they want to scratch.

Thx,
d

ps. FWIW, the last letter in my name is an 'i', not an 'a'.
(I edited the CHANGELOG to reflect this)

>>>>> "Daishi" == Daishi Harada <da...@eg...> writes:

    Daishi> Please let me know if there are any modifications to the
    Daishi> patch which would make it a better candidate for
    Daishi> incorporation into the mainline source.

Hey Daishi,

That is certainly a nice patch and a funky example -- well done.

I was very pleased to see that you added this as a general text
feature and not a feature of text ticks only.  My only suggestions
are: 1) move the dash text class to the text module rather than the axis
module (where it seems to belong since it is a general purpose
connector between a text instance and a point), and 2) provide an example
which uses a generic text instance in addition to the one you provided
using a tick label text instance.

Changes are in CVS -- perhaps you can send me a patch against the
latest revision?

As for the alignment problems (in agg or ps at least), they may be a
result of sf bugs #1194018 and #1177396.

Thanks!
JDH

>>>>> "Nicholas" == Nicholas Young <su...@su...> writes:

    Nicholas> Hi, I made a suggestion for improving imshow performance
    Nicholas> for plotting an image already in byte string form a
    Nicholas> while ago; some of the results are currently in CVS.  I
    Nicholas> seems that other changes made to CVS at the same time or
    Nicholas> since mean that the floating point buffer source code is
    Nicholas> now much faster and I'd suggest taking anything sourced
    Nicholas> from my code back out.

Maybe that explains why I was never able to get the same performance
benefits you were seeing....  But I was able to get 1.5x - 2.5x faster
with your patch, which is pretty damned good.  And the memory
benefit of your patch could be substantial as well.  Why pull it?
What are your latest profiling numbers?

Your patch came in just at the time I was leaving for Paris for a
meeting, after which I experienced a rather nasty total hard drive
failure that set me back in my mpl maintenance.  I am not sure I am
ready to give up on the ideas you introduced....  Can you remind me --
did I manage to incorporate all of the matplotlib.axes and
matplotlib.image patches I needed to take advantage of your patches to
the _image extension code?

JDH