matplotlib-devel Mailing List for matplotlib

On Thu, Jan 6, 2011 at 10:20 AM, Friedrich Romstedt <
fri...@gm...> wrote:

> Hi Ben,
>
> nice to get a response.  It's not an urgent patch, but should go in
> somwhen (imo).  If you could take it and verify that it breaks nothing
> I would owe you a donut ;)
>
> Why OL?
>
> Here's the reference:
> http://thread.gmane.org/gmane.comp.python.matplotlib.general/25103
> Notice that in the email from 18 Oct 14:55, I gave the wrong branch on
> GitHub, it's
> https://github.com/friedrichromstedt/matplotlib/tree/friedrichromstedt-get_cmap
> apparently (not "trunk" branch).
>
> Shall I add it to the bug tracker so that you can assign it maybe to
> yourself?
>
> I long for a matplotlib GitHub repo ... You might use the GitHub
> system to review the patch (it's more readable than a diff file I
> guess).  Here's the link:
>
> https://github.com/friedrichromstedt/matplotlib/commit/1ac794b362d143ac6a634b70993d950d8fe4adeb
> .
>
> Feel free to go on-list, I did not snip away at your response so that
> the on-list history will be complete.
>
> Friedrich
>
> 2011/1/6 Benjamin Root <ben...@ou...>:
> > On Mon, Jan 3, 2011 at 2:36 PM, Friedrich Romstedt
> > <fri...@gm...> wrote:
> >>
> >> 2010/10/19 Friedrich Romstedt <fri...@gm...>:
> >> > The test suite passes except for some failures on my 10.6 Mac OS X
> >> > with yesterday checked-out astraw github repo.  I'll send them in
> >> > another thread.  Let's keep tidy :-)  There's more than the symlog
> >> > error mentioned by LittleBigBrain on my sys.
> >> >
> >> > The failures are identical with and without the patch.
> >> >
> >> > Opinions?
> >>
> >> There has been no response, so I'm resending together with the patch
> >> file.  The patch is created by $ git format-patch -1 on my old git
> >> branch from that time, and can be reapplied by:
> >>
> >> $ patch -p1 <0001-Fixing-bug-in-mpl.cm.get_cmap.patch
> >>
> >> I cannot test it against recent svn because my gcc on Mac OS X went
> >> havoc after restoring the system from Time Machine (the HDD crashed).
> >> Does anybody know what to do when it cannot find even stdarg.h ????
> >>
> >> That time the failures of the test suite did not increase by
> >> introducing the change.  And it fixes LittleBigBrain's bug.
> >>
> >> Annotations from the git commit are in the patch file.  I think it
> >> needs some thinking-through, although I did it carefully, to approve
> >> it.
> >>
> >> Btw what happened to the astraw github mirror?  The latest commit on
> >> branch "trunk" is from November.
> >>
> >> Friedrich
> >>
> >
> > Friedrich,
> >
> > I don't know why you haven't gotten a response on this.  I have not
> looked
> > into it at all though.  Is it a patch that needs to go into 1.0.1?  If
> so, I
> > can make sure it gets there.
> >
> > Ben Root
>

The changes look ok to me so far.  It looks to be mostly a re-organization
of existing logic and some consolidation of code.  My only concerns are the
creation of two new functions.  Besides the obvious issues with potential
namespace collisions in other parts of the code that might do an 'from cm
import *', my main issue is that these functions are probably really only
meant for internal use and should probably start with an underscore.  We can
always un-underscore them in a later release...

I will do a bit more testing to see if I can break it, but barring that, I
will commit a slightly modified version of the patch later today.

Ben Root

P.S. - As for going off-list in my last email, that was an 'oops'.

Hello,

I have been noticing odd behaviors when plotting polygons and surfaces using
mplot3d.  Some polygon faces were being slightly transparent, for example
when you rotate the sphere in the 'surface3d_demo2.py' example.  Some faces
were completely missing, for example in the 'hist3d_demo.py' example.  In
the surface3d_demo3.py example, I wasn't fully happy with the appearance of
the plot and I was fairly sure it wasn't 100% correct.

I believe I have the problem tracked down to the "_shade_colors()" method in
axes3d.py.  I have a patch and it needs to be applied to both the
development branch and one for the release candidate.  However, I am almost
certain that it could break some others 3d display code and I would like
people to check it out first before it gets applied.

The 'mplot3d_vectshade.patch' can be used against the current development
branch, while 'mplot3d_vectshade_rc2.patch' can be used against the latest
in the maintenance branch.

Thanks, and I would greatly appreciate your input!
Ben Root