matplotlib-devel Mailing List for matplotlib

Aha! Even without the text, i.e. setting label1On = False for all the major ticks, the behaviour I see is that with bbox_inches = 'tight' and pad_inches = 0.0 I get the saved figure which includes the black border line for the bottom and left edges, but not the top and right edges. This may have something to do with it. Maybe it's an issue with the bounding box not being 'inclusive' and leaving out the end points?

Regards,
-- Damon

--------------------------
Damon McDougall
Mathematics Institute
University of Warwick
Coventry
CV4 7AL
d.m...@wa...



On 30 Jul 2010, at 20:33, Eric Firing wrote:

> On 07/30/2010 06:32 AM, Damon McDougall wrote:
>> Hmm, it seems as though tick labels get clipped on the top and on the right when passing bbox_inches='tight' and pad_inches=0.0. I wouldn't expect this behaviour. Is there perhaps a bug in Bbox.union that's causing this?
>> 
> 
> Not likely.  Much more likely is a problem in calculating the rendered 
> size of the text.
> 
> Eric
> 
>> Regards,
>> -- Damon
>> 
>> --------------------------
>> Damon McDougall
>> Mathematics Institute
>> University of Warwick
>> Coventry
>> CV4 7AL
>> d.m...@wa...
>> 
>> 
>> 
>> On 30 Jul 2010, at 16:03, Tony S Yu wrote:
>> 
>>> 
>>> On Jul 30, 2010, at 10:54 AM, Damon McDougall wrote:
>>> 
>>>> Hi,
>>>> 
>>>> I'm interested in fiddling around with the matplotlib source. Let's say we set up various things:
>>>> 
>>>> from matplotlib.figure import Figure()
>>>> from matplotlib.backends.backend_pdf import FigureCanvasPdf as FigureCanvas
>>>> 
>>>> fig = Figure()
>>>> canvas = FigureCanvas(fig)
>>>> ax = fig.add_subplot(1, 1, 1)
>>>> fig.savefig('asd.pdf', bbox_inches='tight')
>>>> 
>>>> I would like to know what exactly happens when bbox_inches='tight' is passed to savefig(). I've been searching in the figure.py source and nowhere can I see the bbox_inches='tight' keyword being tested for in the savefig() method. Having said that, all of the kwargs do get passed on to the canvas.print_figure() method, so I looked in the backend_pdf.py file but couldn't find a print_figure() method. Could someone point me in the right direction?
>>>> 
>>>> Regards,
>>>> -- Damon
>>> 
>>> That's funny: I was just looking at bbox_inches='tight' recently. You'll find the relevant section in matplotlib.backend_bases.print_figure.
>>> 
>>> Best,
>>> -Tony
>>> 
>> 
>> 
>> ------------------------------------------------------------------------------
>> The Palm PDK Hot Apps Program offers developers who use the
>> Plug-In Development Kit to bring their C/C++ apps to Palm for a share
>> of $1 Million in cash or HP Products. Visit us here for more details:
>> http://p.sf.net/sfu/dev2dev-palm
>> _______________________________________________
>> Matplotlib-devel mailing list
>> Mat...@li...
>> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
> 
> 
> ------------------------------------------------------------------------------
> The Palm PDK Hot Apps Program offers developers who use the
> Plug-In Development Kit to bring their C/C++ apps to Palm for a share
> of $1 Million in cash or HP Products. Visit us here for more details:
> http://p.sf.net/sfu/dev2dev-palm
> _______________________________________________
> Matplotlib-devel mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel

On 07/30/2010 06:32 AM, Damon McDougall wrote:
> Hmm, it seems as though tick labels get clipped on the top and on the right when passing bbox_inches='tight' and pad_inches=0.0. I wouldn't expect this behaviour. Is there perhaps a bug in Bbox.union that's causing this?
>

Not likely.  Much more likely is a problem in calculating the rendered 
size of the text.

Eric

> Regards,
> -- Damon
>
> --------------------------
> Damon McDougall
> Mathematics Institute
> University of Warwick
> Coventry
> CV4 7AL
> d.m...@wa...
>
>
>
> On 30 Jul 2010, at 16:03, Tony S Yu wrote:
>
>>
>> On Jul 30, 2010, at 10:54 AM, Damon McDougall wrote:
>>
>>> Hi,
>>>
>>> I'm interested in fiddling around with the matplotlib source. Let's say we set up various things:
>>>
>>> from matplotlib.figure import Figure()
>>> from matplotlib.backends.backend_pdf import FigureCanvasPdf as FigureCanvas
>>>
>>> fig = Figure()
>>> canvas = FigureCanvas(fig)
>>> ax = fig.add_subplot(1, 1, 1)
>>> fig.savefig('asd.pdf', bbox_inches='tight')
>>>
>>> I would like to know what exactly happens when bbox_inches='tight' is passed to savefig(). I've been searching in the figure.py source and nowhere can I see the bbox_inches='tight' keyword being tested for in the savefig() method. Having said that, all of the kwargs do get passed on to the canvas.print_figure() method, so I looked in the backend_pdf.py file but couldn't find a print_figure() method. Could someone point me in the right direction?
>>>
>>> Regards,
>>> -- Damon
>>
>> That's funny: I was just looking at bbox_inches='tight' recently. You'll find the relevant section in matplotlib.backend_bases.print_figure.
>>
>> Best,
>> -Tony
>>
>
>
> ------------------------------------------------------------------------------
> The Palm PDK Hot Apps Program offers developers who use the
> Plug-In Development Kit to bring their C/C++ apps to Palm for a share
> of $1 Million in cash or HP Products. Visit us here for more details:
> http://p.sf.net/sfu/dev2dev-palm
> _______________________________________________
> Matplotlib-devel mailing list
> Mat...@li...
> https://lists.sourceforge.net/lists/listinfo/matplotlib-devel

Hmm, it seems as though tick labels get clipped on the top and on the right when passing bbox_inches='tight' and pad_inches=0.0. I wouldn't expect this behaviour. Is there perhaps a bug in Bbox.union that's causing this?

Regards,
-- Damon

--------------------------
Damon McDougall
Mathematics Institute
University of Warwick
Coventry
CV4 7AL
d.m...@wa...



On 30 Jul 2010, at 16:03, Tony S Yu wrote:

> 
> On Jul 30, 2010, at 10:54 AM, Damon McDougall wrote:
> 
>> Hi,
>> 
>> I'm interested in fiddling around with the matplotlib source. Let's say we set up various things:
>> 
>> from matplotlib.figure import Figure()
>> from matplotlib.backends.backend_pdf import FigureCanvasPdf as FigureCanvas
>> 
>> fig = Figure()
>> canvas = FigureCanvas(fig)
>> ax = fig.add_subplot(1, 1, 1)
>> fig.savefig('asd.pdf', bbox_inches='tight')
>> 
>> I would like to know what exactly happens when bbox_inches='tight' is passed to savefig(). I've been searching in the figure.py source and nowhere can I see the bbox_inches='tight' keyword being tested for in the savefig() method. Having said that, all of the kwargs do get passed on to the canvas.print_figure() method, so I looked in the backend_pdf.py file but couldn't find a print_figure() method. Could someone point me in the right direction?
>> 
>> Regards,
>> -- Damon
> 
> That's funny: I was just looking at bbox_inches='tight' recently. You'll find the relevant section in matplotlib.backend_bases.print_figure.
> 
> Best,
> -Tony
> 

On Jul 30, 2010, at 10:54 AM, Damon McDougall wrote:

> Hi,
> 
> I'm interested in fiddling around with the matplotlib source. Let's say we set up various things:
> 
> from matplotlib.figure import Figure()
> from matplotlib.backends.backend_pdf import FigureCanvasPdf as FigureCanvas
> 
> fig = Figure()
> canvas = FigureCanvas(fig)
> ax = fig.add_subplot(1, 1, 1)
> fig.savefig('asd.pdf', bbox_inches='tight')
> 
> I would like to know what exactly happens when bbox_inches='tight' is passed to savefig(). I've been searching in the figure.py source and nowhere can I see the bbox_inches='tight' keyword being tested for in the savefig() method. Having said that, all of the kwargs do get passed on to the canvas.print_figure() method, so I looked in the backend_pdf.py file but couldn't find a print_figure() method. Could someone point me in the right direction?
> 
> Regards,
> -- Damon

That's funny: I was just looking at bbox_inches='tight' recently. You'll find the relevant section in matplotlib.backend_bases.print_figure.

Best,
-Tony

On Fri, Jul 30, 2010 at 9:54 AM, Damon McDougall
<D.M...@wa...>wrote:

> Hi,
>
> I'm interested in fiddling around with the matplotlib source. Let's say we
> set up various things:
>
> from matplotlib.figure import Figure()
> from matplotlib.backends.backend_pdf import FigureCanvasPdf as FigureCanvas
>
> fig = Figure()
> canvas = FigureCanvas(fig)
> ax = fig.add_subplot(1, 1, 1)
> fig.savefig('asd.pdf', bbox_inches='tight')
>
> I would like to know what exactly happens when bbox_inches='tight' is
> passed to savefig(). I've been searching in the figure.py source and nowhere
> can I see the bbox_inches='tight' keyword being tested for in the savefig()
> method. Having said that, all of the kwargs do get passed on to the
> canvas.print_figure() method, so I looked in the backend_pdf.py file but
> couldn't find a print_figure() method. Could someone point me in the right
> direction?
>
> Regards,
> -- Damon
>
>
That is because the FigureCanvasPdf class inherits from the
FigureCanvasBase, which defines the .savefig() function.  You will find that
in backend_bases.py.

I hope this helps,
Ben Root

Hi,

I'm interested in fiddling around with the matplotlib source. Let's say we set up various things:

from matplotlib.figure import Figure()
from matplotlib.backends.backend_pdf import FigureCanvasPdf as FigureCanvas

fig = Figure()
canvas = FigureCanvas(fig)
ax = fig.add_subplot(1, 1, 1)
fig.savefig('asd.pdf', bbox_inches='tight')

I would like to know what exactly happens when bbox_inches='tight' is passed to savefig(). I've been searching in the figure.py source and nowhere can I see the bbox_inches='tight' keyword being tested for in the savefig() method. Having said that, all of the kwargs do get passed on to the canvas.print_figure() method, so I looked in the backend_pdf.py file but couldn't find a print_figure() method. Could someone point me in the right direction?

Regards,
-- Damon

--------------------------
Damon McDougall
Mathematics Institute
University of Warwick
Coventry
CV4 7AL
d.m...@wa...

On 07/29/2010 01:17 PM, Benjamin Root wrote:
> On Thu, Jul 29, 2010 at 3:39 PM, Eric Firing <ef...@ha...
> <mailto:ef...@ha...>> wrote:
>
>     On 07/29/2010 09:31 AM, Benjamin Root wrote:
>     [...]
>      >
>      >     Good catch, Jeff.  Looking over the code, looks like both the
>     input
>      >     data, x, and the weights get similar pre-processing done to
>     ready it
>      >     for histogramming. It appears that a fix was made to how x
>     was being
>      >     processed, but the same was not done to weights.  I have a patch
>      >     that fixes the pre-processing of weights, and also  adds
>     comments to
>      >     both blocks of code to remind future developers to make sure
>     changes
>      >     are made to both chunks of code.
>      >
>      >     The functional part of the change was to check if the first
>     element
>      >     of weights was an iterable or not.  Before, the weights array
>     as in
>      >     the given example would be considered 1-element weights for 3
>      >     datasets, rather than 3-element weights for 1 dataset.
>      >
>      >     Ben Root
>      >
>      >
>      > Re-pinging on my proposed patch.  Also, should it go into just the
>      > trunk, or should it also go into the branch?
>
>     Ben,
>
>     Go ahead, trunk and branch, since it is a bugfix.
>
>     Thank you.
>
>     Eric
>
>
> Done in r8595 and r8596.
>
> As a side-note, it looks like various files that have been changed due
> to svnmerge.py are still showing themselves as having their properties
> modified.  Is this ok?

That seems to be the way svnmerge works--it almost always generates an 
alarming list of property changes.

Eric

>
> Ben Root