cov: use bigger buffer
authorZdenek Kabelac <zkabelac@redhat.com>
Thu, 23 Jan 2025 15:22:25 +0000 (16:22 +0100)
committerZdenek Kabelac <zkabelac@redhat.com>
Thu, 30 Jan 2025 12:38:31 +0000 (13:38 +0100)
Since pvck's  _check_vgname_start is actually checking
up-to (NAME_LEN + 2) bytes  (130),
use at least this size for (MAX_LINE_CHECK + 3).

lib/device/dev-cache.c
libdm/dm-tools/dmsetup.c
tools/pvck.c

index 52f8804c45d4822743d8e95bdbc54b66bf9c8ff0..02ef27edb33b044faf18bc60c7663f4e5d3803a8 100644 (file)
@@ -2384,7 +2384,7 @@ static char *_get_devname_from_devno(struct cmd_context *cmd, dev_t devno)
        static const char _partitions[] = "/proc/partitions";
        char path[PATH_MAX];
        char devname[PATH_MAX] = { 0 };
-       char namebuf[NAME_LEN];
+       char namebuf[NAME_LEN + 1];
        char line[1024];
        unsigned major = MAJOR(devno);
        unsigned minor = MINOR(devno);
index b2cf8009f97ea6061d9915747ceb508e1b53227e..40a5b5038f16cda19f9fc749d75d0cf5571f5afa 100644 (file)
@@ -329,7 +329,7 @@ struct command {
 static int _parse_line(struct dm_task *dmt, char *buffer, const char *file,
                       int line)
 {
-       char ttype[LINE_SIZE], *ptr, *comment;
+       char ttype[LINE_SIZE + 1], *ptr, *comment;
        unsigned long long start, size;
        int n;
 
index 1ea5fc1ad1ddeb6117f9b30963957d4fde2a1619..3b4ce36630cc19648cb304cd8093e0147aec2fc5 100644 (file)
@@ -401,7 +401,7 @@ static int _dump_all_text(struct cmd_context *cmd, struct settings *set, const c
                          int mda_num, uint64_t mda_offset, uint64_t mda_size, char *buf)
 {
        FILE *fp = NULL;
-       char line[MAX_LINE_CHECK];
+       char line[MAX_LINE_CHECK + 3];
        char vgname[NAME_LEN+1];
        char id_str[ID_STR_SIZE];
        char id_first[ID_STR_SIZE];
This page took 0.097043 seconds and 5 git commands to generate.