clang: correcting imprecise prototype

These internal header were using misleading variable names
in function prototypes, but correct names were used in
function definition. Noticed with:

clang-tidy --checks=readability-inconsistent-declaration-parameter-name

No functional change.

diff --git a/device_mapper/libdm-common.h b/device_mapper/libdm-common.h
index cf99265a7aa7815347a074829a41bb5904046cb6..83bd567e6e5750e2075e8ee5eac7245103203ce0 100644 (file)
--- a/device_mapper/libdm-common.h
+++ b/device_mapper/libdm-common.h
@@ -36,7 +36,7 @@ struct target *create_target(uint64_t start,
                             uint64_t len,
                             const char *type, const char *params);
 
-int add_dev_node(const char *dev_name, uint32_t minor, uint32_t major,
+int add_dev_node(const char *dev_name, uint32_t major, uint32_t minor,
                 uid_t uid, gid_t gid, mode_t mode, int check_udev, unsigned rely_on_udev);
 int rm_dev_node(const char *dev_name, int check_udev, unsigned rely_on_udev);
 int rename_dev_node(const char *old_name, const char *new_name,

diff --git a/lib/metadata/metadata.h b/lib/metadata/metadata.h
index 06bb11406328d0e10167e462eef7bb3f08b3bbc7..d860eb65556c9db52f87b94d623770dfc3538855 100644 (file)
--- a/lib/metadata/metadata.h
+++ b/lib/metadata/metadata.h
@@ -384,7 +384,7 @@ void set_pe_align_offset(struct physical_volume *pv, uint64_t data_alignment_off
 int pv_write_orphan(struct cmd_context *cmd, struct physical_volume *pv);
 
 int check_dev_block_size_for_vg(struct device *dev, const struct volume_group *vg,
-                               unsigned int *max_phys_block_size_found);
+                               unsigned int *max_logical_block_size_found);
 int check_pv_dev_sizes(struct volume_group *vg);
 uint32_t vg_bad_status_bits(const struct volume_group *vg, uint64_t status);
 int add_pv_to_vg(struct volume_group *vg, const char *pv_name,

diff --git a/libdm/libdevmapper.h b/libdm/libdevmapper.h
index 69f888d63eee836148889c071e9b7044c4988fe4..c1c6869cb3dc289aaecc3500bceaa589b392da9d 100644 (file)
--- a/libdm/libdevmapper.h
+++ b/libdm/libdevmapper.h
@@ -1235,7 +1235,7 @@ int dm_stats_get_current_area_offset(const struct dm_stats *dms,
                                     uint64_t *offset);
 
 int dm_stats_get_current_area_len(const struct dm_stats *dms,
-                                      uint64_t *start);
+                                      uint64_t *len);
 
 /*
  * Return a pointer to the program_id string for region at the current

diff --git a/libdm/libdm-common.h b/libdm/libdm-common.h
index 30adac03060470b56c7bc18cb9fa8c41d7281fa2..09804c61a71aab4d4fb5ad6e87939d795f87d3e2 100644 (file)
--- a/libdm/libdm-common.h
+++ b/libdm/libdm-common.h
@@ -36,7 +36,7 @@ struct target *create_target(uint64_t start,
                             uint64_t len,
                             const char *type, const char *params);
 
-int add_dev_node(const char *dev_name, uint32_t minor, uint32_t major,
+int add_dev_node(const char *dev_name, uint32_t major, uint32_t minor,
                 uid_t uid, gid_t gid, mode_t mode, int check_udev, unsigned rely_on_udev);
 int rm_dev_node(const char *dev_name, int check_udev, unsigned rely_on_udev);
 int rename_dev_node(const char *old_name, const char *new_name,