test: remove unused --silent option from aux device functions

Remove the unused --silent parameter from aux device management functions:
  - disable_dev()
  - enable_dev()
  - restore_from_devtable()

The --silent option was declared but is never actually used in the function
implementations - no code checked or acted upon this flag.

Updated callers in test scripts:
  - lvchange-raid-transient-failures.sh
  - lvconvert-repair-transient.sh

Both scripts called disable_dev/enable_dev with --silent flag, which is
now removed since it had no effect.

diff --git a/test/lib/aux.sh b/test/lib/aux.sh
index ae0329c244c9b30066c851344b811691c818604b..330fc7df5b55761592500704f48215f2b7274537 100644 (file)
--- a/test/lib/aux.sh
+++ b/test/lib/aux.sh
@@ -1235,17 +1235,13 @@ delay_dev() {
 
 disable_dev() {
        local dev
-       local silent=""
        local error=""
        local notify=""
        local maj
        local min
 
        while [[ -n "$1" ]]; do
-           if [[ "$1" = "--silent" ]]; then
-               silent=1
-               shift
-           elif [[ "$1" = "--error" ]]; then
+           if [[ "$1" = "--error" ]]; then
                error=1
                shift
            else
@@ -1270,12 +1266,6 @@ disable_dev() {
 
 enable_dev() {
        local dev
-       local silent=""
-
-       if [[ "$1" = "--silent" ]]; then
-           silent=1
-           shift
-       fi
 
        rm -f debug.log strace.log
        init_udev_transaction
@@ -1347,12 +1337,6 @@ restore_dm_mirror() {
 # this is a quick way to restore to this table entry
 restore_from_devtable() {
        local dev
-       local silent=""
-
-       if [[ "$1" = "--silent" ]]; then
-           silent=1
-           shift
-       fi
 
        rm -f debug.log strace.log
        init_udev_transaction

diff --git a/test/shell/lvchange-raid-transient-failures.sh b/test/shell/lvchange-raid-transient-failures.sh
index feb9296232507caf869c0e6e48052e83a5869dcf..c7bf2852aceb8b9aac5e93d593776bd93e8ca823 100644 (file)
--- a/test/shell/lvchange-raid-transient-failures.sh
+++ b/test/shell/lvchange-raid-transient-failures.sh
@@ -34,11 +34,11 @@ function _check_raid
        local devs=( "$@" )
 
        aux wait_for_sync $vg $lv
-       aux disable_dev --error --silent "${devs[@]}"
+       aux disable_dev --error "${devs[@]}"
        mkfs.ext4 "$DM_DEV_DIR/$vg/$lv"
        fsck.ext4 -fn "$DM_DEV_DIR/$vg/$lv"
        check raid_leg_status $vg $lv "$fail"
-       aux enable_dev --silent "${devs[@]}"
+       aux enable_dev "${devs[@]}"
        lvs -a -o +devices $vg | tee out
        not grep unknown out
        lvchange --refresh $vg/$lv

diff --git a/test/shell/lvconvert-repair-transient.sh b/test/shell/lvconvert-repair-transient.sh
index 99154f21fbcc5679994c6d4d439812ac82727375..b9da878b74e00b5b89a39ab4f9e32b94507642b9 100644 (file)
--- a/test/shell/lvconvert-repair-transient.sh
+++ b/test/shell/lvconvert-repair-transient.sh
@@ -21,12 +21,12 @@ aux prepare_vg 5
 
 lvcreate -aey --type mirror -m 3 --ignoremonitoring -L 1 -n 4way $vg
 aux wait_for_sync $vg 4way
-aux disable_dev --error --silent "$dev2" "$dev4"
+aux disable_dev --error "$dev2" "$dev4"
 mkfs.ext3 "$DM_DEV_DIR/$vg/4way" &
 sleep 1
 dmsetup status
 echo n | lvconvert --repair $vg/4way 2>&1 | tee 4way.out
-aux enable_dev --silent "$dev2" "$dev4"
+aux enable_dev "$dev2" "$dev4"
 
 lvs -a -o +devices $vg | tee out
 not grep unknown out