From: Vitaly Chikunov <vt@altlinux.org>
Date: Sat, 14 Nov 2020 15:14:28 +0000 (+0300)
Subject: debugedit: Do not 'edit_dwarf2' when just extracting build-id
X-Git-Tag: debugedit-0.1~10
X-Git-Url: https://www.sourceware.org/git/?a=commitdiff_plain;h=87b1d9594459ad36d35240c4f124bc5bf1167d50;p=debugedit.git

debugedit: Do not 'edit_dwarf2' when just extracting build-id

No need to call edit_dwarf2() if debugedit is invoked just to extract
build-id (with `-i -n'). Otherwise, we will get `DWARF version 0
unhandled' warning for compressed .debug files:

  /usr/lib/rpm/debugedit: ./usr/lib/debug/...e.ko.debug: DWARF version 0 unhandled

Context: We have kernel modules elfcompressed in ALT.
---

diff --git a/tools/debugedit.c b/tools/debugedit.c
index c288493..e9d8f3a 100644
--- a/tools/debugedit.c
+++ b/tools/debugedit.c
@@ -2865,7 +2865,8 @@ main (int argc, char *argv[])
 	      fprintf (stderr, "Stabs debuginfo not supported: %s\n", file);
 	      break;
 	    }
-	  if (strcmp (name, ".debug_info") == 0)
+	  if (!(do_build_id && no_recompute_build_id && !base_dir && !dest_dir)
+	      && strcmp (name, ".debug_info") == 0)
 	    edit_dwarf2 (dso);
 
 	  break;