Entity framework savechanges error

Question

I have a wizard step in which a user fills in fields. I then use json to save the values into my database for each wizard step. However, in my repository I have my savechanges(). But it wont save the changes, instead it throws an error:

Entities in 'NKImodeledmxContainer.SelectedQuestion' participate in the 'QuestionSelectedQuestion' relationship. 0 related 'Question' were found. 1 'Question' is expected.

Anyone know how to get rid of the error? Do I have to get the ID from Question and save it aswell to my database or can I change something in EF so the error message is not getting thrown?

This is my post in my controller:

        [HttpPost]
    public JsonResult AnswerForm(int id, SelectedQuestionViewModel model)
    {
        bool result = false;
        var goalCardQuestionAnswer = new GoalCardQuestionAnswer();
        goalCardQuestionAnswer.SelectedQuestion = new SelectedQuestion();

        goalCardQuestionAnswer.SelectedQuestion.Id = model.QuestionID;
        goalCardQuestionAnswer.Comment = model.Comment;
        goalCardQuestionAnswer.Grade = model.Grade;

            if (goalCardQuestionAnswer.Grade != null)
            {

                    answerNKIRepository.SaveQuestionAnswer(goalCardQuestionAnswer);
                    answerNKIRepository.Save();
                    result = true;
                    return Json(result);                   
            }

       answerNKIRepository.SaveQuestionAnswer(goalCardQuestionAnswer);
       answerNKIRepository.Save();

        return Json(result);
    }

My Repository

    public class AnswerNKIRepository
{
    private readonly NKImodeledmxContainer db = new NKImodeledmxContainer();

    public List<SelectedQuestion> GetAllSelectedQuestionsByGoalCardId(int goalCardId)
    {
        return db.SelectedQuestion.Where(question => question.GoalCard.Id == goalCardId).ToList();
    }

    public void SaveQuestionAnswer(GoalCardQuestionAnswer goalCardQuestionAnswer)
    {
        db.GoalCardQuestionAnswer.AddObject(goalCardQuestionAnswer);
    }

    public void Save()
    {
        db.SaveChanges();
    }
}

This is my ViewModel:

 public class SelectedQuestionViewModel
{

    public int? Grade { get; set; }
    public string Comment { get; set; }
    public string SelectedQuestionText { get; set; }
    public int QuestionID { get; set; }
}

This is my database model:

enter image description here

You are not showing what is happening in your repository which is probably most important part of your question. — Ladislav Mrnka
– Ladislav Mrnka, Commented Apr 24, 2012 at 12:57

Slauma · Accepted Answer · 2012-04-24 13:32:40Z

1

The exception complains that SelectedQuestion.Question is a required navigation property but you don't set this property in your code. Try to load the question by Id from the repository and set it to the SelectedQuestion.Question reference: Replace this line ...

goalCardQuestionAnswer.SelectedQuestion.Id = model.QuestionID;

...by...

goalCardQuestionAnswer.SelectedQuestion.Question =
    answerNKIRepository.GetQuestionById(model.QuestionID);

And in your repository add the method:

public Question GetQuestionById(int id)
{
    return db.Question.Single(q => q.Id == id);
}

answered Apr 24, 2012 at 13:32

Slauma

177k60 gold badges407 silver badges424 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

ps__ Over a year ago

With that code i get following error message: "Object reference not set to an instance of an object"

ps__ Over a year ago

At the line you suggested I should replace: "goalCardQuestionAnswer.SelectedQuestion.Question = answerNKIRepository.GetQuestionById(model.QuestionID);"

ps__ Over a year ago

Is there anyway to not get Question enitity involved in my controller? I would prefer just to use SelectedQuestion and GoalCardQuestionAnswer to be used. I need to fill the foreign key in my GoalCardQuestionAnswer entity by SelectedQuestion ID

Slauma Over a year ago

@ps__: Can you check in the debugger if one of the objects goalCardQuestionAnswer or goalCardQuestionAnswer.SelectedQuestion or answerNKIRepository or model is null? I can't imagine the first two are null because you create them with new in the lines before.

Slauma Over a year ago

Your code creates a new SelectedQuestion. Don't you want this? Does the SelectedQuestion already exist in the DB?

|

Collectives™ on Stack Overflow

Entity framework savechanges error

1 Answer 1

10 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

10 Comments

Your Answer

Sign up or log in

Post as a guest

Related