Javascript does not stop submit to server after validation

Question

i am trying to do a form validation using javascript. if error was found the javascript should stop sending the form to the server.

i made sure that the javascript returns false by writing the statement : return false;

and still the form is sent to the server .

script tag:

<script language="javascript" src="validations.js" type="text/javascript"></script>

my form tag:

FORM id="frm" name="newCustomer" METHOD="POST" ACTION="register.php" onsubmit="return validateNewCustomer()">

JavaScript function :

function validateNewCustomer() {
    var name = document.getElementById('f_name').value;

    var okCustomer = true;

    if (name.value == "") {
        document.getElementById('f_name').value="kossetak";
        document.getElementById('errfname').innerHTML = "Error Name";
        okCustomer = false;
    } else {
        document.getElementById('errname').innerHTML = "";
        okCustomer = true;
    }

    return okCustomer;
}

I appreciate your help. Thank you.

Can you post the Javascript function validateNewCustomer()? — Paul
– Paul, Commented May 2, 2012 at 15:54
Where are you returning false? Show all relevant code, please. — Robin Maben
– Robin Maben, Commented May 2, 2012 at 15:54
is there any error in firebug ? Maybe your javascript has errors, and false is not returned, so the form submit — Jerome Cance
– Jerome Cance, Commented May 2, 2012 at 15:55
i've tried using an empty function with the statement return false , and it stops...it seems the problem is in the Javascript code — user1203861
– user1203861, Commented May 2, 2012 at 16:00
Validation should never use true by default. it should always be false unless all checks have been made and your errors is still empty. — Anigel
– Anigel, Commented May 2, 2012 at 16:04

Paul · Accepted Answer · 2012-05-02 16:00:38Z

8

You always return true from your function, because name.value == "" is always false, so you enter the else clause.

Notice that you already have .value on this line:

var name = document.getElementById('f_name').value

So when you say name.value you are accessing document.getElementById('f_name').value.value which will be undefined.

answered May 2, 2012 at 16:00

Paul

142k28 gold badges285 silver badges272 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chris Watts · Accepted Answer · 2012-05-02 16:01:39Z

Perhaps you should consider submitting the form inside your JavaScript function rather than using the HTML action parameter.

An example of this would be:

<form id="frm" name="newCustomer" onsubmit="return validateNewCustomer()">...</form>

JavaScript:

function validateNewCustomer() {
    var name = document.getElementById('f_name').value;

    var okCustomer = true;

    // name.value replaced to name
    if (name == "") {
        document.getElementById('f_name').value="kossetak";
        document.getElementById('errfname').innerHTML = "Error Name";
        okCustomer = false;
    } else {
        document.getElementById('errname').innerHTML = "";
        // Submit the document here
        document.forms["newCustomer"].submit();
        // Still supply a return value in case you need it later
        okCustomer = true;
    }

    return okCustomer;
}

Collectives™ on Stack Overflow

Javascript does not stop submit to server after validation

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related