Pass model between controllers and views in Ruby on Rails

Question

I have signup form on my home screen. If user inputs invalid data I redirect him to /signin page. On this page I can see filled fields, but errors descriptions are empty.

Here is my UsersController:

class UsersController < ApplicationController
  def new
    @user = User.new(params[:user])
  end

  def create
    @user = User.new(params[:user])
    print @user
    if  @user.save

    else
      render 'new'
    end
  end
end

Method I use to show errors

module ApplicationHelper

  def errors_for(model, attribute)
    if model.errors[attribute].present?
      content_tag :div, :class => 'well error' do
        content_tag :ul do
          model.errors[attribute].collect {|item| concat(content_tag(:li, item))}

        end
      end
    end
  end
end

My form partial:

<%= f.label :user_name %>
<%= f.text_field :user_name, :class=>"input-medium" %>
<%= errors_for(@user, :user_name) %>

<%= f.label :email %>

<%= f.text_field :email, :class=>"input-medium " %>

<%= errors_for(@user, :email) %>

<%= f.label :password %>

<%= f.password_field :password, :class=>"input-medium" %>

<%= f.label :password_confirmation, "Confirmation" %>

<%= f.password_field :password_confirmation, :class=>"input-medium" %>

and my signup view:

<section class="centered user-form-container">
  <div class="user-form well pull-left">
    <div class="centered">
      <h1>Sign up</h1>
      <%= form_for(@user, :action=>"create") do |f| %>
          <%= render 'signup', :f=>f %>
          <%= f.submit "Sign up" %>

      <% end %>
    </div>
  </div>

</section>

I post data to create action of this controller and then renders new view template if there are some errors — earsonheart
– earsonheart, Commented May 14, 2012 at 13:21
you have to show us the view code. you must have some code that checks for errors in @user model and eventually show them — coorasse
– coorasse, Commented May 14, 2012 at 13:27

Kevin Bedell · Accepted Answer · 2012-05-14 13:20:43Z

1

In this situation, I believe you need to use flash.now, something like this:

Per the rails docs:

By default, adding values to the flash will make them available to the next request, but sometimes you may want to access those values in the same request. For example, if the create action fails to save a resource and you render the new template directly, that’s not going to result in a new request, but you may still want to display a message using the flash. To do this, you can use flash.now in the same way you use the normal flash:

def create
  @user = User.new(params[:user])
  print @user
  if  @user.save

  else
    # start with this, then expand the error text
    flash.now[:error] = "Could not save user"
    render 'new'
  end

end

answered May 14, 2012 at 13:20

Kevin Bedell

13.5k10 gold badges80 silver badges116 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

earsonheart Over a year ago

I would like to show errors connected to fields next to this fields

Mischa Over a year ago

No, if validation fails @user.errors gets set. That's what he wants to show.

Kevin Bedell Over a year ago

The original question was unclear and didn't specify that -- so I misunderstood the question. My answer is accurate, it's just not what he was looking for. Downvoting seems harsh.

Mischa Over a year ago

If you improve your answer I may undo my downvote, but from this answer it seems you are unfamiliar with validation errors and instead you are suggesting using the flash inappropriately. That's why I downvoted.

Kevin Bedell Over a year ago

Thanks. My point was that the question as originally posed did not ask about validation errors. But I respect your opinion.

cpuguy83 · Accepted Answer · 2012-05-14 14:31:09Z

1

You would do this in your validation method.

If you are using a standard rails validation you would do this:

validates_presence_of :foo, :message => 'Message you want to display here'

If you are doing a custom validation then this:

def my_validation_method
  begin
    my_validation_code_here
  rescue
    self.errors[:base] << 'Message you want to display here'
  end
end

answered May 14, 2012 at 14:31

cpuguy83

6,0234 gold badges22 silver badges24 bronze badges

1 Comment

earsonheart Over a year ago

I have standart messages shown, if i try to sign up directly from signup page. I don't think custom messages will help me here

earsonheart · Accepted Answer · 2012-05-17 13:58:20Z

1

  def new
    @user = User.new(params[:user])
    if (!params[:user].nil?)
      @user.valid?
    end


  end

edited May 17, 2012 at 13:58

answered May 15, 2012 at 11:01

earsonheart

1,0522 gold badges12 silver badges26 bronze badges

Collectives™ on Stack Overflow

Pass model between controllers and views in Ruby on Rails

3 Answers 3

5 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related