Best way to check NULL for objects in Java

Question

I have a solution to check NULL values extracted from object, However i feel there might be best approach than i am doing here. So please suggest me the best ways with code snippet :)

I will be passing my xml Content to unmarshalling method & then pass the unmarshalledValues to null check method (i.e ValidateInputFiled )

Contents unmarshalledValues = unmarshalingContent( xml ); 
inputCheck = ValidateInputField( unmarshalledValues );

I have a POJO for my XML elements as mentioned below,

 @XmlRootElement( name = "contents" )
    public class Contents
    {
        @XmlElement
        String A;

        @XmlElement
        String B;

        @XmlElement
        String C;

        @XmlAttribute
        String D;

       public String getA()
      {
        return A;
      }

       public String getB()
      {
        return B;
      }

       public String getC()
      {
        return C;
      }

       public String getD()
      {
        return D;
      }
}

I have defined ValidateInputFiled as mentioned below

public Boolean ValidateInputField( Contents unmarshalledValues )
    {
        int checker = 0;
        Boolean listCheck = false;

        // Extracting unmarshalled values from xml
        String A= unmarshalledValues.getA();
        String B= unmarshalledValues.getB();
        String C = unmarshalledValues.getC();
        String D= unmarshalledValues.getD();

        if ( A== null || A.isEmpty() )
        {
            checker++;
        }

        if ( B== null || B.isEmpty() )
        {
            checker++;
        }

        if ( C== null || C.isEmpty() )
        {
            checker++;
        }

        if ( D== null || D.isEmpty() )
        {
            checker++;
        }

        if ( checker == 0 )
        {
            listCheck = true;
        }

        return listCheck;

    }

Here i am looking to avoid NULL check for each String Values ( i.e A, B, C, D ) instead can i just do null check for Contents or for unmarshalledValues using collection or list ?

You can also avoid nulls alltogether by coding your getters to return "" if a value == null. Then you would not have to check each field for null. — Logan
– Logan, Commented Jun 8, 2012 at 15:33

Jeff Watkins · Accepted Answer · 2012-06-08 15:26:44Z

6

public static boolean isNullOrEmpty(String a) {
    return a == null || a.isEmpty();
}

Call that for each value. You may want to think about adding them all to a list and then iterating through them, incrementing checker if they're !isNullOrEmpty to save code bloat if you have lots for fields.

PS: Make your fields private to preserve encapsulation.

pps: don't bother with a seperate boolean just return checker == 0; to keep the code neat.

answered Jun 8, 2012 at 15:26

Jeff Watkins

6,35718 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ted Hopp Over a year ago

Rather than counting, OP can just return false; in the body of each test, and return true; at the end of the method (which will be reached only if all tests pass).

NominSim · Accepted Answer · 2012-06-08 15:38:22Z

4

Is that what you are looking for ?

public Boolean ValidateInputField(Contents unmarshalledValues) {
    // Extracting unmarshalled values from xml
    String A = unmarshalledValues.getA();
    String B = unmarshalledValues.getB();
    String C = unmarshalledValues.getC();
    String D = unmarshalledValues.getD();
    return checkNull(A, B, C, D);
}

private static boolean checkNull(String... strings) {
    for (String string : strings) {
        if (string == null || string.isEmpty()) {
            return false;
        }
    }
    return true;
}

edited Jun 8, 2012 at 15:38

NominSim

8,5313 gold badges32 silver badges38 bronze badges

answered Jun 8, 2012 at 15:33

Yanflea

3,9641 gold badge17 silver badges14 bronze badges

1 Comment

Ted Hopp Over a year ago

This would be even better if you changed checkNull to return a boolean value (e.g., noNulls. (It would return false inside the if and true at the end of the method.) Then ValidateInputField could simply return the result of calling noNulls.

Logan · Accepted Answer · 2012-06-08 15:31:04Z

0

I use the apache commons StringUtils library for this type of thing. It has a check that includes null or empty spaces, plus other combinations depending on how you treat empty spaces. Pretty much code like Jeff here gave you, but i like having other methods they include.

You can also avoid nulls alltogether by coding your getters to return "" if a value == null. Then you would not have to check each field for null.

answered Jun 8, 2012 at 15:31

Logan

2,37419 silver badges20 bronze badges

Comments

Matt · Accepted Answer · 2012-06-08 16:19:42Z

0

commons-lang has a Validate class you could use:

Validate.notNull( unmarshalledValues.getA() );

answered Jun 8, 2012 at 16:19

Matt

11.8k2 gold badges28 silver badges35 bronze badges

Comments

Amar Magar · Accepted Answer · 2017-04-03 09:37:53Z

0

Non-reflective solution for Java 8, without using a series of if's, would be to stream all fields and check for nullness:

return Stream.of(id, name).allMatch(Objects::isNull);

This remains quite easy to maintain while avoiding the reflection hammer. This will return true for null attributes.

answered Apr 3, 2017 at 9:37

Amar Magar

8811 gold badge12 silver badges15 bronze badges

Collectives™ on Stack Overflow

Best way to check NULL for objects in Java

5 Answers 5

1 Comment

1 Comment

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related